WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#20809 closed defect (bug) (fixed)

Remove several duplicate strings

Reported by: pavelevap Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: I18N Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

We can remove 4 strings and make translators happier...

There are no string changes, only removing duplicates so it can go into 3.4, I guess...

Patch attached.

Attachments (3)

duplicate_strings.patch (3.5 KB) - added by pavelevap 5 years ago.
20809.diff (6.4 KB) - added by ryan 5 years ago.
duplicate_strings_2.patch (1.1 KB) - added by pavelevap 5 years ago.

Download all attachments as: .zip

Change History (15)

#1 @pavelevap
5 years ago

One string was also reported here: http://core.trac.wordpress.org/ticket/18218#comment:6

On the other hand, I am not sure what is right?

Invalid taxonomy or Invalid Taxonomy?

Are there any rules regarding capital letters in WordPress?

#3 @pavelevap
5 years ago

Hmmm, strange, you are right, but these string occurrences are not present in GlotPress or .pot file. These should be in "Administration" part of translation, right?
Probably due to different files for "Administration" and "Frontend"?

Example:

String: "Invalid post type" (without comma)

In GlotPress there is only 1 occurrence: http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-xmlrpc-server.php#L949

But Sergey found other occurrences of this string related to "Administration" part of translation. This string is probably not added to the "Administration" localization file (because it is already in "Frontend"), but there should be listed all occurrences for translators in GlotPress (and added to .pot files) to see for example context related to occurrences in other file? Now, it is a mess and translators do not see if any string will be also displayed in "Administration" file.

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 3.4

Indeed, those references are no longer included in the .pot files.

Moving for review.

#5 @ryan
5 years ago

They won't be included due to how the admin pot inherits from the frontend pot. The ms pot had the same issue in <= 3.3.

@ryan
5 years ago

#6 @nacin
5 years ago

  • Keywords has-patch commit dev-reviewed added

Looks good.

We can try to fix the references but that would have to happen in makepot.php.

#7 @ryan
5 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [20972]:

Consolodate some strings. Props pavelevap. fixes #20809

#9 @pavelevap
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thank you, but there was another string suggested to merge in my patch.

Updated patch attached (without dots in the end).

Should I create another ticket for adding references to .pot files for inherited strings? Or it will be never possible? It would be really helpfull to see all references due to possible context problems...

#10 @nacin
5 years ago

Should I create another ticket for adding references to .pot files for inherited strings? Or it will be never possible? It would be really helpfull to see all references due to possible context problems...

Yes, feel free to create a ticket. It's definitely something we can experiment with once 3.4 is out the door.

#11 @nacin
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20996]:

Combine 'Invalid term ID.' into the 'Invalid term ID' string. props pavelevap. fixes #20809.

Note: See TracTickets for help on using tickets.