Remove several duplicate strings

[pavelevap]

We can remove 4 strings and make translators happier...

There are no string changes, only removing duplicates so it can go into 3.4, I guess...

Patch attached.

[pavelevap]

One string was also reported here: ​http://core.trac.wordpress.org/ticket/18218#comment:6

On the other hand, I am not sure what is right?

Invalid taxonomy or Invalid Taxonomy?

Are there any rules regarding capital letters in WordPress?

[SergeyBiryukov]

"Invalid post type" and "Invalid taxonomy" are also used in other files:

• ​http://core.trac.wordpress.org/browser/trunk/wp-admin/edit.php?rev=19712#L12
• ​http://core.trac.wordpress.org/browser/trunk/wp-admin/post-new.php?rev=19712#L17
• ​http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-tags.php?rev=19712#L12
• ​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-terms-list-table.php?rev=19712#L22

I'd suggest reviewing the string consolidation suggested in this and the related tickets (#14039, #18218, #19112) in early 3.5.

[pavelevap]

Hmmm, strange, you are right, but these string occurrences are not present in GlotPress or .pot file. These should be in "Administration" part of translation, right?
Probably due to different files for "Administration" and "Frontend"?

Example:

String: "Invalid post type" (without comma)

In GlotPress there is only 1 occurrence: ​http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-xmlrpc-server.php#L949

But Sergey found other occurrences of this string related to "Administration" part of translation. This string is probably not added to the "Administration" localization file (because it is already in "Frontend"), but there should be listed all occurrences for translators in GlotPress (and added to .pot files) to see for example context related to occurrences in other file? Now, it is a mess and translators do not see if any string will be also displayed in "Administration" file.

[SergeyBiryukov]

Indeed, those references are no longer included in the .pot files.

Moving for review.

[ryan]

They won't be included due to how the admin pot inherits from the frontend pot. The ms pot had the same issue in <= 3.3.

[nacin]

Looks good.

We can try to fix the references but that would have to happen in makepot.php.

[ryan]

In [20972]:

Consolodate some strings. Props pavelevap. fixes #20809

[ryan]

​[UT732]

[pavelevap]

Thank you, but there was another string suggested to merge in my patch.

Updated patch attached (without dots in the end).

Should I create another ticket for adding references to .pot files for inherited strings? Or it will be never possible? It would be really helpfull to see all references due to possible context problems...

[nacin]

Should I create another ticket for adding references to .pot files for inherited strings? Or it will be never possible? It would be really helpfull to see all references due to possible context problems...

Yes, feel free to create a ticket. It's definitely something we can experiment with once 3.4 is out the door.

[nacin]

In [20996]:

Combine 'Invalid term ID.' into the 'Invalid term ID' string. props pavelevap. fixes #20809.

[duck_]

​[UT735]