![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 14 years ago
Closed 14 years ago
#21087 closed defect (bug) (fixed)
Combine some similar strings
| Reported by: | pavelevap | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | I18N | Version: | 3.4 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Combine some similar strings with the same meaning - related to the same condition. There is no need to have several different strings.
See attached patch.
Related to #18218, but a little different (not mentioned) case. There are 3 removed strings as a result of this patch.
Attachments (2)
Change History (9)
#4
@
14 years ago
- Resolution fixed
- Status closed → reopened
21087.patch removes one more duplicated string and makes it more consistent with the ones above. Reported by Cátia Kitahara on WP Polyglots.
#5
follow-up:
↓ 7
@
14 years ago
I found other similar strings: "Select Color" and "Select a color". I am not sure which is right and which should be merged?
#7
in reply to: ↑ 5
@
14 years ago
- Resolution → fixed
- Status reopened → closed
Replying to pavelevap:
I found other similar strings: "Select Color" and "Select a color". I am not sure which is right and which should be merged?
Let's leave that alone for now (so, two strings). One is a TinyMCE button tooltip, which has its own style. The other is a "Select Color" button for the color picker.
In [21857]: