Make WordPress Core

Opened 3 years ago

Closed 9 months ago

#21188 closed enhancement (invalid)

Fullscreen (distraction-free) editor should have a preview button

Reported by: markjaquith Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch needs-testing
Focuses: Cc:


Per http://alexking.org/blog/2012/07/06/wordpress-fullscreen-preview-button

I do find it annoying to have to exit fullscreen, preview, then flip back to fullscreen.

Attachments (1)

21188.diff (2.0 KB) - added by MikeHansenMe 17 months ago.
First pass

Download all attachments as: .zip

Change History (18)

comment:1 @Ipstenu3 years ago

  • Cc ipstenu@… added

comment:2 @sabreuse3 years ago

  • Cc sabreuse@… added

comment:3 @tillkruess3 years ago

  • Cc me@… added

comment:4 @hakre3 years ago

  • Cc hanskrentel@… added

comment:5 @azaozz18 months ago

  • Milestone changed from Awaiting Review to 3.9

Moving to 3.9 for consideration.

comment:7 @ircbot17 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

@MikeHansenMe17 months ago

First pass

comment:8 @MikeHansenMe17 months ago

  • Keywords has-patch needs-testing added

comment:9 @helen17 months ago

Doesn't quite feel right as an editor button, and that eye is still creepy. Secondary button next to update/publish?

comment:10 @MikeHansenMe17 months ago

That was my first thought as well, however when I put a secondary button the "Saved" text broke to the next line. I was also thinking about if the "Save" button was translated the space would be even tighter. Happy to give it another go if you have some suggestions for the space issue.

comment:11 @azaozz17 months ago

The DFW toolbar needs responsive styling, perhaps that can be handled there? Seems it can wrap to two lines: the Exit fullscreen, Save, Preview buttons at the top and the editor buttons at the bottom? Also "Exit fullscreen" should probably be a button.

comment:12 @nacin17 months ago

  • Keywords punt added
  • Type changed from feature request to enhancement

Preview is also really tough to get right from an implementation standpoint, as it actually has to POST data under most conditions (for previewing what's currently been written, versus the last revision), versus just open up the preview URL. Alex King's hack had used the underlying preview button, which is pretty clever (at least as a hack, not suggesting that's how we should implement it).

comment:13 @nacin17 months ago

  • Keywords punt removed
  • Milestone changed from 3.9 to Future Release

comment:14 @hardeepasrani9 months ago

Just wanted to notify that Just Writing has this feature in it, so you may wanna look into its coding to get some inspiration out of it for your own patch :)

comment:15 @johnbillion9 months ago

This ticket will be invalidated when #29806 lands. DFW as we know it will be replaced with an in-place distraction free mode rather than a separate modal view.

comment:16 @hardeepasrani9 months ago

Yikes! Now that ticket is in my watch list. You just can't keep your eyes away from the trac :) Thanks for notifying, John.

comment:17 @johnbillion9 months ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

#29806 has landed, effectively rendering this moot.

Note: See TracTickets for help on using tickets.