Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21635 closed enhancement (fixed)

Add slideshare oEmbed support

Reported by: Tyrun Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:


Adding speakerdeck and slideshare oEmbed support

Attachments (1)

speakerdeck-slideshare-oembed.diff (869 bytes) - added by Tyrun 3 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 @Tyrun3 years ago

#21632 thanks for the inspiration and getting the discussion started!!

comment:2 @bradparbs3 years ago

  • Cc brad@… added

comment:3 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:4 @scribu3 years ago

Speakerdeck is rather new, no?

comment:5 @SergeyBiryukov3 years ago

Moved primarily for SlideShare.

comment:6 @DrewAPicture3 years ago

+1 for adding SlideShare.

-1 for Speaker Deck. At barely a year old, I'm not sure its usage is widespread enough to justify adding core support just yet. There's already a plugin in the repo, Speaker Deck Embed with < 300 downloads.

comment:7 @Tyrun3 years ago

Yes it is young, but many people are using it.

Additionally I think that providing support for services that makes 'magic' happen that just makes it easy for end users is a good thing.

I agree with Jaquith's thoughts on #21632, that the process of knowing that it can be done, knowing to look for a plugin to do it and then installing the plugin is too much for most people. At the cost of an additional element in an array I think it's definitely worth it.

comment:8 @scribu3 years ago

It's not just "the cost of an additional element in an array". Each element in the array is another regex that the content of each post needs to go through, on each page load.

comment:9 @Tyrun3 years ago

I see, I did not think of that. I still think having it available is a good thing to have.

Also the regex is only run on post save/update, correct?

comment:10 @scribu3 years ago

No, it's run on post display.

comment:11 @tyrun3 years ago

Ok - so for 3.5 should we just remove speakerdeck and just add support for slideshare?

comment:12 @nacin3 years ago

  • Summary changed from Add speakerdeck and slideshare oEmbed support to Add slideshare oEmbed support

Slideshare is in, as long as its oEmbed endpoint is sane. It should be checked out for obeying sane maxheight and maxwidth values.

comment:13 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [22003]:

Add soundcloud and slideshare to the oEmbed providers list. props bradparbs, ericwahlforss, wonderboymusic. fixes #15734, #21635.

comment:14 @tyrun3 years ago

Hey @nacin, think I could possible get added to the contributors list since this was my ticket? It's my first ticket and I was really hoping to make the contributors list!

Also - does anyone have any idea how to change your handle on trac? I'd prefer to be aaronholbrook instead of my old handle of tyrun.

Note: See TracTickets for help on using tickets.