Add slideshare oEmbed support

[Tyrun]

Adding speakerdeck and slideshare oEmbed support

[Tyrun]

#21632 thanks for the inspiration and getting the discussion started!!

[scribu]

Speakerdeck is rather new, no?

[SergeyBiryukov]

Moved primarily for SlideShare.

[DrewAPicture]

+1 for adding SlideShare.

-1 for Speaker Deck. At barely a year old, I'm not sure its usage is widespread enough to justify adding core support just yet. There's already a plugin in the repo, ​Speaker Deck Embed with < 300 downloads.

[Tyrun]

Yes it is young, but many people are using it.

Additionally I think that providing support for services that makes 'magic' happen that just makes it easy for end users is a good thing.

I agree with Jaquith's thoughts on #21632, that the process of knowing that it can be done, knowing to look for a plugin to do it and then installing the plugin is too much for most people. At the cost of an additional element in an array I think it's definitely worth it.

[scribu]

It's not just "the cost of an additional element in an array". Each element in the array is another regex that the content of each post needs to go through, on each page load.

[Tyrun]

I see, I did not think of that. I still think having it available is a good thing to have.

Also the regex is only run on post save/update, correct?

[scribu]

No, it's run on post display.

[tyrun]

Ok - so for 3.5 should we just remove speakerdeck and just add support for slideshare?

[nacin]

Slideshare is in, as long as its oEmbed endpoint is sane. It should be checked out for obeying sane maxheight and maxwidth values.

[nacin]

In [22003]:

Add soundcloud and slideshare to the oEmbed providers list. props bradparbs, ericwahlforss, wonderboymusic. fixes #15734, #21635.

[tyrun]

Hey @nacin, think I could possible get added to the contributors list since this was my ticket? It's my first ticket and I was really hoping to make the contributors list!

Also - does anyone have any idea how to change your handle on trac? I'd prefer to be aaronholbrook instead of my old handle of tyrun.