Make WordPress Core

Opened 12 years ago

Last modified 5 years ago

#21913 new enhancement

Detecting MIME Types in WXR Files

Reported by: readymadeweb's profile ReadyMadeWeb Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4.2
Component: Import Keywords: dev-feedback needs-refresh
Focuses: Cc:

Description

In the process of creating a service to convert TypePad data to WXR formatted files, we've encountered some unique problems with TypePad data. Namely, many TypePad files are saved without file extensions, which prevents the existing importer from importing those files into the wp-content/uploads folder.

In order to import and rename these otherwise ignored files, we've created a patch for the WordPress importer that does the following:

  1. If there is an attachment in the WXR and the importer is not able to determine the file type from the file name (ie missing extension), the patched version will make a light (body-less) request to the web server where the file is hosted for information we can use about the file. The things we're interested in are file type, size, and filename.
  1. If the importer is processing an attachment under the above situation, and it is able to determine the file type, then it will rewrite the local version of the file to have the appropriate file extension.

This is a simple bit of code, but it makes a huge difference as TypePad saves without file extensions quite regularly.

We've attached our patch and a sample WXR file from ragsgupta.com, the Brightcove co-founder's blog.

Attachments (3)

readymadeweb-filetype.patch (3.5 KB) - added by ReadyMadeWeb 12 years ago.
Patch to WordPress Importer
www.ragsgupta.com-16.zip (519.6 KB) - added by ReadyMadeWeb 12 years ago.
Sample WXR File with Missing File Extensions
readymadeweb-filetype-HEAD.patch (4.1 KB) - added by ReadyMadeWeb 12 years ago.

Download all attachments as: .zip

Change History (14)

@ReadyMadeWeb
12 years ago

Patch to WordPress Importer

@ReadyMadeWeb
12 years ago

Sample WXR File with Missing File Extensions

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to WordPress.org

#2 follow-ups: @nacin
12 years ago

Rather than using cURL, we have an HTTP API. You can use wp_remote_head() to send a HEAD request, then use wp_remote_retrieve_header() on the response to get a specific header.

We also use lowercase true/false/null.

Also, please use svn diff rather than the GNU diff tool to create patches. It can still be applied with patch but contains SVN metadata (and is properly recognized by our bug tracker).

#3 @ReadyMadeWeb
12 years ago

We'll adjust and submit a new patch soon.

#4 @ReadyMadeWeb
12 years ago

Nacin, I've uploaded a new version for your review.

#5 @ReadyMadeWeb
11 years ago

A patch file readymadeweb-filetype-HEAD.patch has been uploaded and is ready for review.

#6 in reply to: ↑ 2 @ReadyMadeWeb
11 years ago

Replying to nacin:

Rather than using cURL, we have an HTTP API. You can use wp_remote_head() to send a HEAD request, then use wp_remote_retrieve_header() on the response to get a specific header.

We also use lowercase true/false/null.

Also, please use svn diff rather than the GNU diff tool to create patches. It can still be applied with patch but contains SVN metadata (and is properly recognized by our bug tracker).

All of these issues have been addressed and a new version of the patch is uploaded. Still not sure if I'm using this forum correctly. Please excuse the excess comments.

#7 @readymadeweb
11 years ago

  • Keywords dev-feedback 2nd-opinion added
  • Version set to 3.4.2

#8 @readymadeweb
11 years ago

  • Cc readymadeweb added

#9 in reply to: ↑ 2 @readymadeweb
11 years ago

New patch is posted!

Replying to nacin:

Rather than using cURL, we have an HTTP API. You can use wp_remote_head() to send a HEAD request, then use wp_remote_retrieve_header() on the response to get a specific header.

We also use lowercase true/false/null.

Also, please use svn diff rather than the GNU diff tool to create patches. It can still be applied with patch but contains SVN metadata (and is properly recognized by our bug tracker).

#10 @nacin
11 years ago

#22157 was marked as a duplicate.

#11 @chriscct7
9 years ago

  • Keywords needs-refresh added; has-patch 2nd-opinion removed
Note: See TracTickets for help on using tickets.