Make WordPress Core

Opened 3 years ago

Closed 13 months ago

#21950 closed enhancement (fixed)

Don't create shared terms

Reported by: scribu Owned by: boonebgorges
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords:
Focuses: Cc:

Description (last modified by scribu)

Step 1: Split shared terms: #5809

Step 2: Don't create new shared terms: this ticket.

Step 3: Profit.

Change History (12)

#1 @scribu
3 years ago

  • Description modified (diff)

#2 @greenshady
3 years ago

  • Cc justin@… added

#3 @sirzooro
3 years ago

  • Cc sirzooro added

#5 @SergeyBiryukov
3 years ago

#23199 was marked as a duplicate.

#6 @Chouby
3 years ago

  • Cc frederic.demarle@… added

#7 @johnbillion
3 years ago

  • Cc johnbillion added

#8 @alexvorn2
3 years ago

  • Cc alexvornoffice@… added

this should have a higher priority

#9 @wonderboymusic
2 years ago

  • Keywords needs-patch added

This ticket was mentioned in IRC in #wordpress-dev by simonwheatley. View the logs.

17 months ago

#11 @boonebgorges
13 months ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 4.1
  • Owner set to boonebgorges
  • Status changed from new to accepted

The recent patches on #5809 will resolve this ticket.

#12 @boonebgorges
13 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 30240:

Do not create shared taxonomy terms.

A "shared" term occurs when two entries in the wp_term_taxonomy table share a
single term_id, and thereby correspond to the same row in wp_terms. This
changeset stops the practice of creating shared terms: each new row in
wp_term_taxonomy will receive its own row in wp_terms. The new strategy
for term creation depends on whether the installation's database schema is up
to date for 4.1:

  • If so, terms are allowed to be created with the same slug as an existing term, as long as they are in different taxonomies and do not share a parent. Thus, a new tag with the slug 'wordpress' can exist alongside a category with the slug 'wordpress'.
  • If not, new terms will be forced to have unique slugs. Thus, on an installation containing a category with the slug 'wordpress', a new tag 'WordPress' will get the slug 'wordpress-2'.

Fixes #21950. See #5809.

Note: See TracTickets for help on using tickets.