Opened 12 years ago
Closed 10 years ago
#22183 closed enhancement (fixed)
Input type="email" and type="url"
Reported by: | johnbillion | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | commit |
Focuses: | Cc: |
Description
Text inputs for email addresses were replaced with email inputs in [20168] but reverted in [20196] due to poor client-side validation by Chrome 17 and Firefox 10, however we've had input type="email" on the registration form since [18763].
We should:
- Test the current state of client-side validation.
- Either introduce email inputs in the admin area or revert [18763] depending on the results of point 1.
See http://core.trac.wordpress.org/ticket/17863#comment:25 for the email input validation issue.
Attachments (3)
Change History (14)
@
12 years ago
Changes email to text on wp-login.php (in case we don't go with the novalidate route)
#5
@
12 years ago
- Milestone changed from 3.5 to Future Release
Let's try to bring these back (sans validation) in a future release.
#6
@
10 years ago
- Summary changed from Input type="email" to Input type="email" and type="url"
I've wrote a new patch with the current dev version. The patch will fix not only type="email"
but also type="url"
where ever it should be used for usabilty reasons.
It also adds the novalide="novalidate"
in XHTML syntax to all <form>
tags concidering the mentioned validation issue in FF.
This patch is proudly presented by the WordCamp Hamburg Contributor Day. #wchh14
#7
@
10 years ago
- Milestone changed from Future Release to 4.0
Someone should decide if we want this
#8
@
10 years ago
- Keywords needs-testing added
This needs some good cross-browser testing with IDNs. I'll see what I can do.
#9
@
10 years ago
- Keywords commit added; has-patch needs-testing removed
Looks like we're good to go. The novalidate
attribute allows the form to be submitted in the following browsers which otherwise reject valid IDNs:
- Chrome 28 and earlier (desktop and Android)
- Firefox 12 and earlier
- IE10 & IE11
For completeness:
- Safari (desktop and iOS) does not perform any validation
- Android browser does not perform any validation
- Opera (tested up to 22) correctly handles IDN validation
Tested using BrowserStack with the following URL: https://johnblackbourn.com/idn.php
I went through all of wp-admin. That wp-login.php was not reverted was indeed a mistake.
Setting the forms to novalidate should be sufficient, if that remains a concern. Context-sensitive mobile keyboards is, in my opinion, more important than validation.