Blog path included in base

[scribu]

Previously: #19796

My config:

define('MULTISITE', true);
define('SUBDOMAIN_INSTALL', false);
$base = '/core/';
define('DOMAIN_CURRENT_SITE', 'wp.dev');
define('PATH_CURRENT_SITE', '/core/');
define('SITE_ID_CURRENT_SITE', 1);
define('BLOG_ID_CURRENT_SITE', 1);

When I go to Network Admin -> Sites, the list of blogs looks like this:

/core/
/core/foo/
/core/bar/

and then, if I go to edit /core/bar/, I can change /core/ to something else, making that particular blog inaccessible.

[scribu]

I think the most elegant way to go about this would be to combine the Path and Domain input fields into a single URL input and then use parse_url() to update the relevant bits.

And, if the new path doesn't start with $base, we can show an error message and refuse to save it.

[scribu]

22235.diff​ is the start of a patch. It doesn't validate the base yet.

Looking at the additional logic in get_blogaddress_by_domain(), I get the impression that my patch will break something, but I'm not sure what.

[SergeyBiryukov]

Possibly related: #18242

[wpmuguru]

Why

echo $protocol; echo esc_html( $site_url_no_http );

instead of

echo $protocol . esc_html( $site_url_no_http );

[scribu]

No reason; that's how it was originally.

[scribu]

I'm not sure this is such a big deal anymore. I mean, you could just change the domain completely and MS won't stop you, even if you don't have domain mapping enabled.

Created a new ticket for combining the fields: #22383

[nacin]

Was this a regression? I was under the opinion that it was.

[scribu]

It would be a regression, if we did any validation before, like checking that the user didn't change the domain.

[nacin]

Replying to scribu:

It would be a regression, if we did any validation before, like checking that the user didn't change the domain.

But we didn't... So this is not a regression and has been around since the merge, yes? If so, punting. Feel free to close as a duplicate of #22383 if you think they can merge.

[scribu]

Correct. Going to close as maybelater, in case we ever want to start adding comprehensive validation.

[wpmuguru]

Replying to nacin:

Replying to scribu:

It would be a regression, if we did any validation before, like checking that the user didn't change the domain.

But we didn't... So this is not a regression and has been around since the merge, yes?

Yes.