Gallery re-order not working in WP 3.5, Update Gallery button just closes dialogue

[chrsdgtl]

I checked some of the other tickets, none reference this error that I saw.

"Update Gallery" button triggers dialogue window closing, with no action.

Seems to be an issue in load-scripts.php line number 451: "g is null" is the error... if you go to that line.. g seems to reference...

var g=document.documentElement.style

[chrsdgtl]

Just to clarify, this is of course after attempting to reorder images in a gallery via "drag and drop."

[wycks]

I can confirm this. The gallery is not updated when selecting just "Update Gallery" it just closes the window.

The gallery setting are only updated when you "Update" the post, this might be the intended method.

[chrsdgtl]

To wycks point I do not get the preferred order when I "update" the post either. Which is the sequence I go through anyway: re-order --> update gallery settings (where error occurs) --> "update" post." I focused on the update gallery button because thats where I see the error occurring in the console.

Tested in Mac Chrome, Safari, and Firefox.

[wycks]

tested on Chrome, My update works, but I do get a JS error.

Cannot call method 'get' of null media-views.min.js:1
f.controller.Library.f.controller.State.extend.refreshContent media-views.min.js:1
g.Events.trigger backbone.min.js:9
f.extend.reset backbone.min.js:22
f.controller.Library.f.controller.State.extend.reset media-views.min.js:1
g.Events.trigger backbone.min.js:9
(anonymous function) underscore.min.js:5
T.map.T.collect underscore.min.js:5
T.invoke underscore.min.js:5
r.(anonymous function) backbone.min.js:25
f.view.Frame.f.View.extend.reset media-views.min.js:1
toolbar.set.f.view.Toolbar.items.insert.click media-views.min.js:1
f.view.Button.f.View.extend.click media-views.min.js:1
v.event.dispatch jquery.js:2
o.handle.u

The specific error is trigger on line 525 of media-views.js.

if ( this.active && ! selection.length && ! router.get( mode ) )

[lessbloat]

Fairly certain 22930.diff​ will fix this.

[SergeyBiryukov]

FWIW, 22930.diff​ reverts [23051].

[koopersmith]

In 23260:

Media: Check that a router region exists before attempting to access its child views. Add relevant documentation. see #22930.

[nacin]

In 23268:

Media: Check that a router region exists before attempting to access its child views. Add relevant documentation.

Merges [23260] to the 3.5 branch.

props koopersmith.
fixes #22930.