Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23215 closed enhancement (fixed)

Don't use deprecated WP_Screen::is_network property.

Reported by: bpetty Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:


Just updates WP_Plugins_List_Table to use $screen->in_admin( 'network' ) instead of the deprecated is_network property.

is_network was deprecated in r21687 (#21742), and while this might normally use in_network_admin(), it's possible to pass in a custom WP_Screen into WP_List_Table (which might happen in unit tests or maybe some ajax calls), so in this case, the replacement continues to use the same screen object instead.

Attachments (1)

23215.patch (6.7 KB) - added by bpetty 3 years ago.

Download all attachments as: .zip

Change History (3)

3 years ago

#1 @SergeyBiryukov
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6

#2 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23658:

Replace deprecated WP_Screen::is_network property with WP_Screen::in_admin( 'network' ). props bpetty. fixes #23215.

Note: See TracTickets for help on using tickets.