Some files still have closing PHP tags

[SergeyBiryukov]

[19712] removed EOF ?> from nearly all the files, including wp-content/index.php:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/index.php

In a couple of files, however, it's still there, which doesn't seem intentional:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/plugins/index.php
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/themes/index.php

We should probably make the same change there for consistency.

[kraftbj]

Removed closing ?> tags from mentioned files.

[MikeHansenMe]

couple more from wp-admin/includes

[bpetty]

A lot of those wp-admin/includes are 3rd party libraries, so upstream changes on those are preferred.

[MikeHansenMe]

Makes sense, my bad.

[SergeyBiryukov]

[19712] was for 3.4, so it's the earliest applicable version here.

[kraftbj]

Ah, I understand. I was thinking 2.8 as when the original index.php files were added, which introduced the issue of the EOF closure. But makes sense that if that didn't become a solid convention until 3.4, then that is the applicable version.

Thanks for the clarification.

[SergeyBiryukov]

#25126 was marked as a duplicate.

[SergeyBiryukov]

In 28678:

Remove closing PHP tags from the rest of index.php files in wp-content, for consistency with wp-content/index.php.

props kraftbj.
fixes #23505.