Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#23505 closed enhancement (fixed)

Some files still have closing PHP tags

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: lowest
Severity: trivial Version: 3.4
Component: Bootstrap/Load Keywords: has-patch
Focuses: Cc:


[19712] removed EOF ?> from nearly all the files, including wp-content/index.php:

In a couple of files, however, it's still there, which doesn't seem intentional:

We should probably make the same change there for consistency.

Attachments (2)

23505.patch (677 bytes) - added by kraftbj 11 years ago.
Removed closing ?> tags from mentioned files.
23505.wp-admin-includes.diff (1.2 KB) - added by MikeHansenMe 11 years ago.
couple more from wp-admin/includes

Download all attachments as: .zip

Change History (13)

11 years ago

Removed closing ?> tags from mentioned files.

#1 @kraftbj
11 years ago

  • Cc bk@… added
  • Keywords has-patch added

11 years ago

couple more from wp-admin/includes

#2 @MikeHansenMe
11 years ago

  • Cc mdhansen@… added

#3 @bpetty
11 years ago

A lot of those wp-admin/includes are 3rd party libraries, so upstream changes on those are preferred.

#4 @MikeHansenMe
11 years ago

Makes sense, my bad.

#5 @kraftbj
11 years ago

  • Version changed from 3.4 to 2.8

#6 @SergeyBiryukov
11 years ago

  • Version changed from 2.8 to 3.4

[19712] was for 3.4, so it's the earliest applicable version here.

#7 @kraftbj
11 years ago

Ah, I understand. I was thinking 2.8 as when the original index.php files were added, which introduced the issue of the EOF closure. But makes sense that if that didn't become a solid convention until 3.4, then that is the applicable version.

Thanks for the clarification.

#8 @SergeyBiryukov
11 years ago

#25126 was marked as a duplicate.

#9 @nacin
10 years ago

  • Component changed from General to Bootstrap/Load

#10 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.0

#11 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28678:

Remove closing PHP tags from the rest of index.php files in wp-content, for consistency with wp-content/index.php.

props kraftbj.
fixes #23505.

Note: See TracTickets for help on using tickets.