Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#23618 closed defect (bug) (fixed)

Twenty Eleven: use new URL extraction function for ephemera widget

Reported by: lancewillett's profile lancewillett Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The goal is to replace the URL grabber in Twenty Eleven with the new core version while ensuring back compat.

See #23570 for the suggested new functions.

Attachments (1)

23618.diff (2.3 KB) - added by obenland 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 follow-up: @nacin
11 years ago

Seems like [23474] was in reference to this ticket? I opened #23674, and don't think it should be pluggable.

#2 in reply to: ↑ 1 @lancewillett
11 years ago

Replying to nacin:

Seems like [23474] was in reference to this ticket? I opened #23674, and don't think it should be pluggable.

Not related.

Obenland and I were auditing all functions in Twenty Thirteen and I looked back at the other themes as saw this was the only non-pluggable function, and fixed it -- your thoughts one #23674 make sense, though.

@obenland
11 years ago

#3 @obenland
11 years ago

  • Keywords has-patch added; needs-patch removed

#4 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23792:

Twenty Eleven: use new URL extraction function, get_the_url() for link post formats in the Ephemera widget. Props obenland, fixes #23618.

#5 @lancewillett
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Now that the_post_format_* functions are removed from core, Twenty Eleven should use get_content_url instead in the twentyeleven_get_first_url() function.

See also #24469.

#6 @lancewillett
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24434:

Twenty Eleven: use get_content_url() instead of get_the_post_format_url(). Fixes #23618.

Note: See TracTickets for help on using tickets.