WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#23657 closed defect (bug) (fixed)

Twenty Thirteen: Don't show comment link on single post views

Reported by: markmcwilliams Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

It seems pointless to show the comment link, when they're literately just below that link!

I know it links to the comment area, but it looks out of place?

The other only suggestion I have is to move it up beside the likes of the date, category and any tags?

See the attached screenshots, and patch.

Attachments (4)

leave-comment-before.png (18.4 KB) - added by markmcwilliams 5 years ago.
leave-comment-after.png (17.6 KB) - added by markmcwilliams 5 years ago.
23657.diff (696 bytes) - added by markmcwilliams 5 years ago.
23657.2.diff (3.6 KB) - added by markmcwilliams 5 years ago.

Download all attachments as: .zip

Change History (11)

@markmcwilliams
5 years ago

#1 @obenland
5 years ago

I can see where you're coming from. There might be an author bio and (lots of) comments between the link and the comment form, though.

#2 follow-up: @markmcwilliams
5 years ago

In theory, the author bio isn't going to be overly large. But as it stands, unless you have multiple authors, that doesn't show anyway. There's maybe an argument if, like you say, there's lots of comments. I'd say for the majority of users, it'll be out of place though.

#3 in reply to: ↑ 2 @obenland
5 years ago

Replying to markmcwilliams:

There's maybe an argument if, like you say, there's lots of comments. I'd say for the majority of users, it'll be out of place though.

Actually there is not, I was wrong. If there are comments it links to the comment list. Let's get rid of it on single pages, good call markmcwilliams.

#4 follow-up: @obenland
5 years ago

  • Keywords needs-refresh added; 2nd-opinion removed

Could you update your patch to include the post format templates (content-*.php)?

#5 @lancewillett
5 years ago

  • Milestone changed from Awaiting Review to 3.6

#6 in reply to: ↑ 4 @markmcwilliams
5 years ago

  • Keywords needs-refresh removed

Replying to obenland:

Could you update your patch to include the post format templates (content-*.php)?

Yeah, sure, done! :)

#7 @lancewillett
5 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23621:

Twenty Thirteen: remove extraneous comment link on single post views, props markmcwilliams. Fixes #23657.

Note: See TracTickets for help on using tickets.