Explicitly globalize version variables

[nbachiyski]

When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be.

For example, if in a unit test there is no way to access $wp_version. Neither via $wp_version (it's not in the same scope), not via $GLOBALS['wp_version'] (it's not a global).

To fix that we need to explicitly make the version variables global.

See #17749.

[nacin]

We sometimes include version.php in local scope inside a function on purpose, so we can get untainted variables (say, for an update check).

So, we would actually want to globalize these variables where this file is included (specifically wp-settings.php).

[nbachiyski]

Now I understand. In the previous ticket dd32 mentioned this, but I thought of something else. Sorry about the wasted cycles.

Here is a patch, which works for me.

[wonderboymusic]

these are all marked 3.7-early

[SergeyBiryukov]

If you load a Multisite install in a function (by including wp-load.php), you'll get an error:

Fatal error: Call to a member function set_prefix() on a non-object in wp-includes/ms-settings.php on line 126

Tested in 3.3, 3.5.1, and trunk. See the ​IRC discussion.

Perhaps we should explicitly globalize $wpdb as well.

[wonderboymusic]

In 26008:

When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be. Explicitly make the version variables global.

Props nbachiyski.
Fixes #23685.

[dd32]

In [26008]

That commit applied both patches here, where it was only one or the other that was intended on being applied I think.

Adding the globals to version.php will mean that if a plugin is overwriting the $wp_version variable (to prevent the version being displayed or something) we'll then re-overwrite it. That's OK to me, but is worth noting.

Since we always include version.php within the update checks, this should still mean we use an untainted version variable though.

Also, SergeyBiryukov's comment regarding $wpdb is still valid, but should probably be pushed to another ticket.

[wonderboymusic]

I spaced - which one is preferred?

[wonderboymusic]

In 26009:

Don't globalize version variables twice. See #23685.