Opened 12 years ago
Closed 12 years ago
#23903 closed enhancement (fixed)
Revisions compare tweaks: Title, "To:" header
Reported by: | markjaquith | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Revisions | Keywords: | has-patch dev-feedback |
Focuses: | Cc: |
Description (last modified by )
- The "To:" header doesn't make sense when looking at a single revision. It should just show the revision. No "To:" prefix.
- The first line of the Diff is the title. But that isn't made clear. It just looks like part of the text. Maybe, if there is a title diff, that should be prefixed with "Title:".
To summarize: less prefixing except when more prefixing.
Attachments (7)
Change History (15)
#5
in reply to:
↑ 4
@
12 years ago
- Keywords dev-feedback added
Replying to faishal:
thank you for you patch!
it worked as expected but i reworked a couple of things in 23903.diff
- show/hide the To: area using only CSS, no JS required as we area already adding a class to a parent div when the user switches to the compare two mode
- cleaned up the label creation as per WordPress coding standards
also, please note that its best to generate your diff from the root, that makes it easier to apply for testing :)
#7
@
12 years ago
To clarify: __( ucfirst( str_replace( 'post_', '', $field ) ) )
may work in this case, because we already have the strings in _wp_post_revision_fields()
:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/post.php#L4878
But it's not a good example of i18n, as gettext won't be able to parse it:
http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/
23903.2.diff reuses the strings from _wp_post_revision_fields()
.
Replying to markjaquith:
also excerpt field is revisioned and will show up too & probably needs a label