WordPress.org

Make WordPress Core

#24175 closed defect (bug) (fixed)

Image post format insertion results in a broken image for unlinked images

Reported by: designsimply Owned by:
Milestone: 3.6 Priority: high
Severity: normal Version: 3.6
Component: Post Formats Keywords: close
Focuses: Cc:

Description (last modified by wonderboymusic)

Steps to reproduce:

  1. Go to Appearance > Themes and activate the Twenty Twelve theme
  2. Go to Posts > Add New
  3. Click the "Image" post format at the top
  4. Click "Select / Upload Image"
  5. Upload a new image and set Link To = None
  6. Click "Select Image"
  7. Note that the "_format_image" textarea contains a link even though I selected Link To = None (looks like a separate bug), remove the anchor tag so just the img tag is left (that's the expected behavior for what I selected). See the highlighted part of the first screenshot below for an example.
  8. Click "Publish"
  9. View the post
  • Expected: to see an image post format appear normally with the image showing
  • Actual: no image appears and I see the following mangled HTML:
<div class="post-format-content">
<p><img src="&lt;img src=" http:="" threedotonefour.com="" wp-content="" uploads="" 2013="" 01="" img_3754.jpg"="" width="300" height="225" alt="IMG_3754" class="wp-image-223 alignright size-medium">” alt=”" /&gt;</p></div>

http://f.cl.ly/items/2e3L0J3A1I1P0q1T1o2S/Screen%20Shot%202013-04-24%20at%2011.51.25%20AM.png

http://f.cl.ly/items/402c3I2N3L0n050k3n2G/Screen%20Shot%202013-04-24%20at%2011.53.12%20AM.png

Tested with

  • WP Trunk r24075
  • Twenty Twelve theme
  • Chrome 26

Notes

  • I see the same problem regardless of whether I use the "Select / Upload Image" link to add the image.
  • As long as the "Image HTML or URL" field contains an unlinked image with code similar to the example above, the image appears broken on the front end.
  • The same problem happens even if you simplify the HTML in the "Image HTML or URL" field to something like <img src="http://threedotonefour.com/wp-content/uploads/2013/01/DCP00684.jpg" />

This is *very* similar to #24147 but the output HTML is different.

Attachments (1)

24175.diff (2.5 KB) - added by wonderboymusic 12 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 ryan12 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:2 wonderboymusic12 months ago

This is the result of a bad merge of patches - on it!

wonderboymusic12 months ago

comment:3 wonderboymusic12 months ago

  • Keywords has-patch added
  • Version set to trunk

comment:4 wonderboymusic12 months ago

  • Description modified (diff)

comment:5 markjaquith12 months ago

In 24078:

Fix mangled image output in compat function.

props wonderboymusic. see #24175.

comment:6 aaroncampbell11 months ago

  • Keywords close added; has-patch removed

Several things have changed so I can't follow the steps exactly, but from what I can tell this is fixed:

  • In [24226] the "Attachment Display Settings" section of the media modal was hidden, so you can't set a "Link To" there anymore
  • In [24289] we made sure that no link was filled in anywhere when you select an image or when you upload one using the new DND functionality
  • In [24078] wonderboymusic fixed the mangled output.

I think this is ready to be closed as fixed.

comment:7 markjaquith11 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.