WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#24458 closed defect (bug) (fixed)

Remove attachment_url_to_postid()

Reported by: aaroncampbell Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-codex has-patch
Focuses: Cc:
PR Number:

Description (last modified by aaroncampbell)

For A/V shortcodes, include the attachment ID instead of just the URL, making attachment_url_to_postid() unnecessary.

Transition those IDs on import

Remove attachment_url_to_postid()

As per http://make.wordpress.org/core/2013/05/29/post-formats-ui-is-exiting-core-will-live-as-a-plugin/

Attachments (5)

24458.diff (1.3 KB) - added by markjaquith 6 years ago.
24458.2.diff (527.7 KB) - added by markjaquith 6 years ago.
24458.3.diff (3.2 KB) - added by markjaquith 6 years ago.
without all the extra stuff
24458.4.diff (1.1 KB) - added by kovshenin 6 years ago.
24458.5.diff (2.7 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 @DrewAPicture
6 years ago

  • Keywords needs-codex added

For removal from the Codex list.

#3 @aaroncampbell
6 years ago

  • Description modified (diff)

@markjaquith
6 years ago

#4 @markjaquith
6 years ago

Adds shortcode support for id=attachment_id. Seems to work. Overrides src. Now to have the JS set that when embedding.

@markjaquith
6 years ago

#5 @markjaquith
6 years ago

Uses id when creating audio/video embeds now.

@markjaquith
6 years ago

without all the extra stuff

@kovshenin
6 years ago

#6 @kovshenin
6 years ago

In 24458.4.diff: stop using attachment_url_to_postid in img_html_to_post_id.

#7 @wonderboymusic
6 years ago

  • Keywords has-patch added; needs-patch removed

Removes func and includes kovshenin's changes in 24458.5.diff

#8 @nacin
6 years ago

In 24548:

Remove attachment_url_to_postid(). props kovshenin, wonderboymusic. see #24458.

#9 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

See #24791 for importin'.

Note: See TracTickets for help on using tickets.