Editing images with GD breaks with streams

[rmccue]

See #18543 for the original ticket when support for this was added.

Unfortunately, when this was committed, it was inadvertently broken. Although the $filename parameter is set to null, this is never used, and instead $arguments is passed to the GD functions. GD then receives a stream URL, and breaks completely.

Instead, $arguments[1] should be set to null in WP_Image_Editor::make_image() if the URL is a stream.

[nacin]

markoheijnen, DH-Shredder?

[rmccue]

For reference, you can reproduce via App Engine, disabling the ​workaround code in there (line 508).

[markoheijnen]

The patch looks fine to me. Did remove the $dst_file variable in my patch since that isn't needed anymore.

[markoheijnen]

Added a new patch that moves this logic to the GD editor. We can check if arguments[1] is set and then unset it but you never know what other implementation someone has. With previous patches imagick will fatal error since it would send 2 arguments instead of only 1.

I did some basic tests but not yet with streams. My laptop is crashing randomly.

[markoheijnen]

Ryan, can you test out the latest patch?

[nacin]

24459.4.diff​ seems to make sense to me.

[aaroncampbell]

I tested 24459.4.diff​ and it seems to work for me.

[ryan]

I tested editing images and creating headers (from uploads and from library) on wordpress.com with local and replicated files. Seems fine, looks good.

[ryan]

In 24727:

Fix editing images with GD when using streams.

Props rmccue, markoheijnen, nacin
fixes #24459