WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25026 closed defect (bug) (fixed)

Twenty Fourteen: 'masthead-fixed' class is not removed after window returns to top

Reported by: cainm's profile cainm Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Twenty Fourteen adds the masthead-fixed class to the #masthead element when a user begins to scroll. When the window returns to the top, this class should be removed.

Attachments (1)

ticket25026.diff​ (636 bytes) - added by cainm 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @cainm
11 years ago

  • Keywords has-patch added

#2 @iamtakashi
11 years ago

The patch looks good to me and removes the class so that the shadow disappear when the window returns to the top. Thanks cainm.

#3 @iamtakashi
11 years ago

Cainm: One small note for making patches for core Trac. I believe we prefer patches being made from WordPress root rather than from the theme directory in this case.

@cainm
11 years ago

#4 @cainm
11 years ago

iamtakashi: Thanks for the note. I updated the patch.

#5 @lancewillett
11 years ago

  • Milestone changed from Awaiting Review to 3.8

#6 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25062:

Twenty Fourteen: remove masthead-fixed class after window returns to top. Props cainm, fixes #25026.

Note: See TracTickets for help on using tickets.