WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 9 years ago

#25055 closed defect (bug) (maybelater)

Add in_theme_update_message-$themeid action to theme update table.

Reported by: pross's profile pross Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: Themes Keywords:
Focuses: Cc:

Description

Plugins have this action and i think themes used to as well.

This patch gets it working again.

Attachments (2)

theme.patch​ (670 bytes) - added by pross 11 years ago.
theme.2.patch​ (679 bytes) - added by pross 11 years ago.
Added $update as 2nd arg

Download all attachments as: .zip

Change History (7)

@pross
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Component changed from Administration to Themes
  • Milestone changed from Awaiting Review to 3.7
  • Version changed from trunk to 3.6

Plugins have this action and i think themes used to as well.

They still do: tags/3.6/wp-admin/includes/update.php#L283​. However, wp_theme_update_row() only runs in network admin.

For consistency with the existing instance, $update should be passed as a second argument.

@pross
11 years ago

Added $update as 2nd arg

#2 @nacin
11 years ago

  • Keywords needs-docs added
  • Milestone changed from 3.7 to 3.8

#3 follow-up: @nacin
11 years ago

  • Milestone changed from 3.8 to Future Release

Lots changed here in 3.8. Moving to future pending a new review.

#4 in reply to: ↑ 3 @obenland
10 years ago

  • Keywords close added

Replying to nacin:

Lots changed here in 3.8.

Including the way update notices work now. Adding an action wouldn't help, we'd have to filter the output.

I don't think it's vital to add. If it's only to achieve parity with plugins this won't work anyway, due to the difference in how update notices are handled in themes now.

#5 @chriscct7
9 years ago

  • Keywords has-patch needs-docs close removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Closing per comment:4 and general lack of interest over the last 2 years

Note: See TracTickets for help on using tickets.