set_group fails on deregistered but not dequeued

[tivnet]

This:

add_action('wp_print_scripts', function () {
	wp_deregister_script('autosave');
});

results in:

PHP Notice:  Undefined index: autosave in class.wp-scripts.php on line 169
PHP Notice:  Trying to get property of non-object in class.wp-scripts.php on line 169

With wp_dequeue_script('autosave');, everything is fine.

But without dequeue, probably, the attached patch might help.

[tivnet]

@nacin
Any resolution on this? Thank you!

[SergeyBiryukov]

Appears to be a duplicate of #20912 (which has the same use case and the same patch).

[nacin]

Hm. #20912 was closed.

[tivnet]

I checked again, with 3.8 - and there was no warning.
However, theoretically, args can be null

	public function add( $handle, $src, $deps = array(), $ver = false, $args = null ) {
		if ( isset($this->registered[$handle]) )
			return false;
		$this->registered[$handle] = new _WP_Dependency( $handle, $src, $deps, $ver, $args );
		return true;
	}

So, checking for if ( $this->registered[$handle]->args === 1 ) may produce warnings.
I believe, the code will be safer with the patch.

[chriscct7]

Refreshed patch. Good to go.

[wonderboymusic]

In 34862:

Scripts: in WP_Scripts::set_group(), the args prop of the _WP_Dependency instance defaults to null - check that it is set before comparing.

Props tivnet, chriscct7.
Fixes #25462.