Opened 11 years ago
Closed 11 years ago
#25508 closed defect (bug) (fixed)
Hooks Docs: wp-includes/admin-bar.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Inline Docs | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Patch forthcoming
Attachments (3)
Change History (13)
#3
@
11 years ago
- Keywords needs-patch added; has-patch removed
@swissspidy: Thanks for the patch. :)
Just a few things that need fixed:
General:
- All short/long descriptions and @param descriptions need periods at the end.
wp_admin_bar_class
:
- Change @param to
@param WP_Admin_Bar The WP_Admin_Bar instance, passed by reference.
wp_before_admin_bar_render
:
- Remove the blank line after @since, as there's no parameters to be listed.
show_admin_bar
:
- s/wheter/whether in short description and @param description.
- Change long description to say that
show_admin_bar
is the recommended way to hide the toolbar. - Existing long description should be moved to the @param description, like:
* @param bool $show_admin_bar Whether the admin bar should be shown. Default 'false'. * The user's display preference is used for logged in users.
Could you make these changes and upload a new patch please? :)
Also, please do not overwrite your existing patch. If you use the same filename, Trac will append a number to the filename to indicate it's a new version. We like to keep all patch versions for the ticket history.
#6
@
11 years ago
Just updated the patch to respect your mentioned points.
I only disagree with the wp_admin_bar_class
filter. It doesn't pass the instance by reference, only the name of the class to instantiate.
#9
@
11 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 3.8
25508.3.diff looks good.
Note: See
TracTickets for help on using
tickets.
First pass at inline docs for this file's hooks.