Update about page for WordPress 3.7

[jorbin]

Another pass

[nacin]

markjaquith and I took jorbin's text and turned it into this (see 25603.4.diff​ for the very rough cut). The images were a cut-and-paste job from some sample about page designs that melchoyce did. Yes, that is an actual working password meter. markjaquith and I have plans to fill it with default values (add a character every second and watch as it cycles through each level, before clearing it again - until the user focuses on the field to try it themselves).

Please critique the text in particular. The UI needs work; suggestions are also welcome. But finalizing the text is key in order to hit RC1.

The screenshot didn't cut off remaining Under the Hood items — there are only three. The others just aren't very compelling. (Even the multisite one isn't very compelling.) Let's keep it simple.

[nacin]

In 25832:

Update the text for the about page, so translators can get started. Design is in flux.

props nacin, markjaquith, jorbin, jenmylo.
see #25603.

[nacin]

With [25832], the lid is closed on the text (barring any typos). jorbin is working on the password meter and he and melchoyce I think are trying to improve the page visually. I'm okay with doing this right after RC1 — important part is the strings for translators.

[nacin]

In 25833:

Check if background core updates are supported on about.php.

see #25603, #22704.

[nacin]

In 25834:

Remove redundant code. see #25603, #22704, [25833].

[jorbin]

My new patch adds some animation and a working password strength meter.

[melchoyce]

This latest patch adds images into the page to help illustrate the major sections.

I ran into some issues trying to size the images. No matter what size image I use, the page resizes it to 100px x whatever is proportionate. I have no idea how to fix it to use the native image size. Right now, I'm using the 2x-sized images for better quality.

[melchoyce]

Just kidding. Image sizes should be fixed in 25603.7.diff​.

[jorbin]

refreshed my patch to include mel's patch. Also fixed a race condition and renamed the file so it is more generic and we can then reuse the new about.js in the future when it might not be an animation.

[jorbin]

latest patch removes all include styles and an unneeded ternary. It will need some small fixes for older IEs (it's using nth-child right now), but should be good to get all the strings finalized.

[nacin]

In 25839:

Awesome about page design for WordPress 3.7.

The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.

[nacin]

In 25840:

Remove rarr from about page text. Use a subtle background instead.

props markjaquith.
see #25603.

[nacin]

mark and I are not color experts — I defer to melchoyce if she wants to change the colors we used in [25840]. I just wanted to make sure the arrow was dropped from the strings, so translators could get to work.

Remaining issues (none are RC-blocking):

• Better alignment of the input and password meter. Stupid content-box.
• Older IEs.
• When the animation resets, it stays on "Strong" for a time. This odd flicker happens with a normal meter too, but it's more glaring when it is an animation (at 200% size no less). Would be nice to fix.

[TobiasBg]

Should the animated password "Gosh, WordPress is grand." be offered for translation and passed into the script via wp_localize_script?

[SergeyBiryukov]

Replying to TobiasBg:

Should the animated password "Gosh, WordPress is grand." be offered for translation and passed into the script via wp_localize_script?

I had the same thought, but the string isn't actually visible in the password meter.

[TobiasBg]

Ha, true, it's a password field after all :-) Nice one!

[Jayjdk]

I can't see the images on a multisite install.

It tries to find the images at http://example.com/wp-admin/network/images/[name].png but the actual images are at http://example.com/wp-admin/images/[name].png

[ocean90]

Replying to Jayjdk:

I can't see the images on a multisite install.

That's right. I think they are just placeholder and will be loaded from wordpress.org later.

[nacin]

Replying to ocean90:

Replying to Jayjdk:

I can't see the images on a multisite install.

That's right. I think they are just placeholder and will be loaded from wordpress.org later.

We did this for screenshots in 3.6 to keep the package size down. But this about page is very simplistic, and the images are only a few kilobytes each. So I committed them in [25839].

I'll change these to use full paths.

[nacin]

In 25842:

Use full paths to images so they work on wp-admin/network/about.php and user/about.php. see #25603.

[ocean90]

In 25844:

CSS cleanup for the about page.

Also fixes for IE and support for RTL.

see #25603.

[nacin]

In 25845:

About page: Use box-sizing: border-box on the password meter so pixels line up.

Also eliminates a duplicate width: 100% property.

fixes #25603.

[ocean90]

In 25846:

IE7: Fix width of the password input field on the about page. see #25603.

[nacin]

In 25847:

Since we're dealing with a huge password meter, don't bold half of the result strings unnecessarily. see #25603.

[nacin]

In 25848:

About page: Prevent the meter from briefly sticking on 'Strong' when the animation resets.

props jorbin.
see #25603.

[ocean90]

In 25849:

Vendor-prefixes for [25845]. props jorbin. see #25603.

[pixolin]

Perhaps the wrong place to report that, but having plugin MP6 installed, the about page looks somewhat screwed:
​http://imgur.com/JA0xBvo

[SergeyBiryukov]

Replying to pixolin:

Perhaps the wrong place to report that, but having plugin MP6 installed, the about page looks somewhat screwed:
​http://imgur.com/JA0xBvo

Also reported in IRC: ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-10-18&sort=asc#m709151. Will be fixed in MP6.

[knutsp]

Related (?): ​http://meta.trac.wordpress.org/ticket/211

[knutsp]

Replying to knutsp:

Related (?): ​http://meta.trac.wordpress.org/ticket/211

Deactivate WordPress Beta Tester plugin, delete the transient wordpress_credits_$locale or wait 24 h for expiration, then revisit credits.php. It seems this plugin manipulates the version parameter of every (!) request to the WordPress.org API. This side effect is reported to the plugin authors.

[jorbin]

25603.16.diff adjusts the speed to be a bit faster and have a bit less variance.

Also, I took a look at the performance and each lookup to zxcvbn was taking the most amount of time, so I added a simple cache so that we don't hit zxcvbn after the first time through.

[jorbin]

IRC conversion on why we are reopening ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-10-23&sort=asc#m711570

[nacin]

As reported in IRC by boogah (also in discussion: jorbin, ipstenu, DH-Shredder, dotben), there are a few issues with the way the about page presents the background update status of the site:

• It exposes the email address to everyone. Authors can see the admin_email, and in multisite, anyone can see the network admin email. (This email address is supposedly used for communication with users, but that's not really the case.) Suppressing the email is therefore necessary.

• If auto updates are 100% disabled, we'll claim that we'll email users of pending updates — but that's not true, as the update notification is currently baked directly into the automatic updater class. I snuck in a comment yesterday in [25873], you can see it at the top: "This [100% disabling] also disables update notification emails. That may change in the future."

The solution proposed in 25603.20.diff​ does the following:

• current_user_can( 'update_core' ) is required to view the site's status.
• If the automatic updater is 100% disabled, we don't show anything either. This only happens for DISALLOW_FILE_MODS (for which current_user_can( 'update_core' ) fails anyway), AUTOMATIC_UPDATER_DISABLED, and the automatic_updater_disabled filter. Note that this constant and filter is the updater, not particular updates. To only disable core updates, you will want to use the auto_update_core filter, the WP_AUTO_UPDATE_CORE constant, or the various allow_*_auto_core_updates filters (where * is 'dev', 'minor', and 'major').
• It assumes that if the user can update_core, they can see the admin email.
• It hides the notice about the email when the filter notify_core_update returns false. This is a new filter in the patch. Basically, this is a filter that is more general than the automatic updater, for a time in the future (probably 3.8) when emails are specifically top-level, rather than piggybacked to the updater process. (Thus, merely blocking the updater will not be enough to block emails in the future.)
• Adds the notify_core_update filter because the filter auto_core_update_send_email also blocks critical failure and update success emails. We don't want people using that filter to block *notification* emails, because they might accidentally block fail/success emails as well. That _send_email filter isn't even run for 'manual' (update notification) emails anymore.

[nacin]

Just to be clear, 100% disabling the updater with AUTOMATIC_UPDATER_DISABLED (or the like) doesn't just prevent core updates, it also prevents plugin, theme, and translation updates. Translation updates are on by default; the other two can be turned on with a filter.

[nacin]

With filter name change. send_core_update_notification_email

[markjaquith]

Seems good. New filter name is more clear.

[azaozz]

In 25603.24.diff: cleaned up 25603.17.diff and replaced _.shuffle() with Math.floor( Math.random() * timesForAnimation.length ) as suggested by @nacin.

[nacin]

In 25882:

Introduce a send_core_update_notification_email filter to control whether to send update notifications.

Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.

[nacin]

In 25883:

About page, updates section: Don't show a message on about.php if the updater is 100% disabled. Don't show it if the user can't update core. Don't show the email if notifications are disabled. New string.

see #25603.

[nacin]

In 25884:

About page: Cache our zxcvbn calls and limit the variation of the animation.

Diff is mostly whitespace.

props jorbin, azaozz.
fixes #25603.

[nacin]

In 25885:

Introduce a send_core_update_notification_email filter to control whether to send update notifications.

Merges [25882] to the 3.7 branch.

Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.

[nacin]

In 25886:

About page, updates section: Don't show a message on about.php if the updater is 100% disabled. Don't show it if the user can't update core. Don't show the email if notifications are disabled. New string.

Merges [25883] to the 3.7 branch.
see #25603.

[nacin]

In 25887:

About page: Cache our zxcvbn calls and limit the variation of the animation.

Merges [25884] to the 3.7 branch.

Diff is mostly whitespace.

props jorbin, azaozz.
fixes #25603.

[azaozz]

25603.25.diff adds a long-missing </div> to fix html validation.