Opened 11 years ago
Closed 11 years ago
#25654 closed defect (bug) (fixed)
Auto core update emails might advertise the wrong version
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch commit i18n-change |
Focuses: | Cc: |
Description
Background updates are a separate "offer" via the API, as in, one can be told to update from 3.7.2 to 3.8.1, but we can also silently serve an auto-update in-branch, to 3.7.3, to that site. This enables us to keep sites secure even when they are running relatively recent but out-of-date branches.
The code that handles the emails for auto-updates will simply use the auto-update version number. As in, "WordPress %2$s is available. Please update!" Rather than telling them 3.7.3, we should tell them that 3.8.1 is available.
If an auto update to 3.7.3 is successful, we should replace "No further action is needed on your part." with "WordPress 3.8.1 is also available. Updating is easy and only takes a few moments:" (The first sentence there is a new string).
If an auto update to 3.7.3 is unattempted or failed, we should simply tell them that we tried but couldn't update their site, and that they should update to 3.8.1 now.
If an auto update to 3.7.3 critically failed, we currently say "Your site at %1$s experienced a critical failure while trying to update to the latest version of WordPress, %2$s." That's not good, as it might not be the latest version. We do however say "If it says you need to update, you should do so:", so that email doesn't need to change otherwise.
Attachments (3)
Change History (10)
#3
follow-up:
↓ 4
@
11 years ago
25654.2.diff looks good to me
One question, why this change though?
If things are successful and we're now on the latest, mention plugins and themes if any are out of date.
#4
in reply to:
↑ 3
@
11 years ago
- Keywords i18n-change added
Replying to dd32:
25654.2.diff looks good to me
One question, why this change though?
If things are successful and we're now on the latest, mention plugins and themes if any are out of date.
If we're already telling them that they should go update core, that's the call to action I care most about. When they do, they'll find that plugins and themes are out of date.
Only if they have no other call to action (core is running the latest version, everything is OK) should we include a little note about plugins/themes. That's at least how I originally envisioned it, that's why that line only appears in success emails.
25654.diff is an untested swipe at the issues raised above