WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25870 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-admin/about.js

Reported by: jorbin Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description


Attachments (3)

25870.dotnotation.diff (903 bytes) - added by jorbin 7 years ago.
25870.global.diff (318 bytes) - added by jorbin 7 years ago.
25870.all.diff (1.6 KB) - added by kadamwhite 7 years ago.

Download all attachments as: .zip

Change History (8)

@jorbin
7 years ago

#1 @jorbin
7 years ago

  • Component changed from General to Unit Tests
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

@kadamwhite
7 years ago

#2 @kadamwhite
7 years ago

  • Cc kadamwhite@… added

Now, putting aside the fact that this file will probably be going away.

25870.all.diff contains the same changes @jorbin made, plus a minor optimization to cache the reused jQuery object in a $result. I'd like to take this opportunity to make changes like this if we're editing the same lines for JSHint coverage, but I want to run that by jorbin, nacin et al.

#3 @SergeyBiryukov
7 years ago

  • Component changed from Unit Tests to Build Tools

#4 @nacin
7 years ago

25870.all.diff looks good, but in this case, this file will be removed in 3.8 anyway.

#5 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26065:

Avoid JSHint errors. Use dot notation when able and declare pwsL10n as a global.

props jorbin.
fixes #25870.

Note: See TracTickets for help on using tickets.