Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#25945 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-includes/js/shortcode.js

Reported by: tommcfarlin Owned by: nacin
Priority: normal Milestone: 3.8
Component: Build/Test Tools Version:
Severity: normal Keywords:
Cc: Focuses:

Description

The included patch for this ticket will resolve JSHint errors for the Shortcode JS file.

Additional description of the changes will be coming once the patch is complete.

Attachments (1)

shortcode.diff​ (4.0 KB ) - added by tommcfarlin 13 years ago.
Resolving the JSHint errors regarding conditional braces and unused function argumnets.

Download all attachments as: .zip

Change History (5)

#1 follow-up: @nacin
13 years ago

  • Summary jshint shouldn't throw errors - wp-admin/js/shortcode.js → jshint shouldn't throw errors - wp-includes/js/shortcode.js

This file is actually wp-includes/js/shortcode.js.

#2 in reply to: ↑ 1 @tommcfarlin
13 years ago

Replying to nacin:

This file is actually wp-includes/js/shortcode.js.

Yeah - was in the habit of typing the wp-admin/js path when creating tickets. Thanks for the catch!

The proper file will be patched considering it doesn't exist elsewhere :).

@tommcfarlin
13 years ago

Resolving the JSHint errors regarding conditional braces and unused function argumnets.

#3 @nacin
13 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 26228:

Fix JSHint errors in shortcode.js.

props tommcfarlin.
fixes #25945.

#4 @SergeyBiryukov
13 years ago

  • Milestone Awaiting Review → 3.8
Note: See TracTickets for help on using tickets.