WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#25945 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-includes/js/shortcode.js

Reported by: tommcfarlin Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

The included patch for this ticket will resolve JSHint errors for the Shortcode JS file.

Additional description of the changes will be coming once the patch is complete.

Attachments (1)

shortcode.diff (4.0 KB) - added by tommcfarlin 5 months ago.
Resolving the JSHint errors regarding conditional braces and unused function argumnets.

Download all attachments as: .zip

Change History (5)

comment:1 follow-up: nacin5 months ago

  • Summary changed from jshint shouldn't throw errors - wp-admin/js/shortcode.js to jshint shouldn't throw errors - wp-includes/js/shortcode.js

This file is actually wp-includes/js/shortcode.js.

comment:2 in reply to: ↑ 1 tommcfarlin5 months ago

Replying to nacin:

This file is actually wp-includes/js/shortcode.js.

Yeah - was in the habit of typing the wp-admin/js path when creating tickets. Thanks for the catch!

The proper file will be patched considering it doesn't exist elsewhere :).

tommcfarlin5 months ago

Resolving the JSHint errors regarding conditional braces and unused function argumnets.

comment:3 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26228:

Fix JSHint errors in shortcode.js.

props tommcfarlin.
fixes #25945.

comment:4 SergeyBiryukov5 months ago

  • Milestone changed from Awaiting Review to 3.8
Note: See TracTickets for help on using tickets.