Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#26008 closed defect (bug) (fixed)

jshint shouldn't throw errors: wp-admin/js/set-post-thumbnail.js

Reported by: atimmer Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:


9 errors to fix.

Attachments (1)

26008.1.diff (1.1 KB) - added by atimmer 2 years ago.

Download all attachments as: .zip

Change History (5)

2 years ago

#1 @atimmer
2 years ago

  • Keywords has-patch added; needs-patch removed

#2 @nacin
2 years ago

Rather than window., we're going to use /* global */. This is in part to help us identify globals we use and ideally cut down on them in the future. Or in this case, to self-flog ourselves for using confirm() and alert().

#3 @nacin
2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26199:

Fix JSHint errors in 3 files.

props atimmer.
fixes #25990, #25993, #26008.

#4 @nacin
2 years ago

  • Milestone changed from Awaiting Review to 3.8

Moving fixed JSHint error tickets to 3.8.

Note: See TracTickets for help on using tickets.