WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#26095 closed defect (bug) (fixed)

Hook Docs (17): wp-includes/rewrite.php

Reported by: mboynes Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch
Focuses: docs Cc:

Description

Attached patch has docs for the following hooks in wp-includes/rewrite.php:

  • url_to_postid
  • post_rewrite_rules
  • date_rewrite_rules
  • root_rewrite_rules
  • comments_rewrite_rules
  • search_rewrite_rules
  • author_rewrite_rules
  • page_rewrite_rules
  • $permastructname . '_rewrite_rules'
  • tag_rewrite_rules
  • generate_rewrite_rules
  • rewrite_rules_array
  • mod_rewrite_rules
  • rewrite_rules
  • iis7_url_rewrite_rules
  • permalink_structure_changed

Attachments (3)

rewrite.php.diff (11.1 KB) - added by mboynes 5 months ago.
Adding inline docs for hooks in wp-includes/rewrite.php
26095.diff (9.1 KB) - added by DrewAPicture 8 weeks ago.
2nd pass
26095.2.diff (9.1 KB) - added by DrewAPicture 7 weeks ago.
final pass

Download all attachments as: .zip

Change History (10)

mboynes5 months ago

Adding inline docs for hooks in wp-includes/rewrite.php

comment:1 DrewAPicture5 months ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

comment:2 DrewAPicture4 months ago

  • Summary changed from Hook Docs: wp-includes/rewrite.php to Hook Docs (17): wp-includes/rewrite.php

Hi, thanks for the patch. I should have a more thorough review for you later today, but it looks like most of the long descriptions will need a once-over, as well as reverting some of the whitespacing changes that aren't directly related the hooks we're documenting here.

comment:3 jeremyfelt3 months ago

  • Component changed from Inline Docs to Rewrite Rules
  • Focuses docs added

DrewAPicture8 weeks ago

2nd pass

comment:4 DrewAPicture8 weeks ago

  • Owner changed from DrewAPicture to kpdesign

26095.diff cleans up a bunch of descriptions, reverts unnecessary code changes and other changes.

The language could all use a once-over, with particular attention to the mod_rewrite_rules, rewrite_rules and iis7_url_rewrite_rules filters. Not 100 percent on the wording of those descriptions.

DrewAPicture7 weeks ago

final pass

comment:5 DrewAPicture7 weeks ago

  • Milestone changed from Awaiting Review to 3.9

comment:6 DrewAPicture7 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27341:

Inline documentation for hooks in wp-includes/rewrite.php.

Props mboynes for the initial patch.
Fixes #26095.

comment:7 DrewAPicture7 weeks ago

In 27346:

Fix a typo in the author_rewrite_rules hook doc.

Props kpdesign.
See #26095.

Note: See TracTickets for help on using tickets.