Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26277 closed defect (bug) (invalid)

Codex entry on "register post type" has incorrect information

Reported by: beowulfenator's profile beowulfenator Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Permalinks Keywords:
Focuses: Cc:


The Codex entry on the "register_post_type" function contains inaccurate information about the "rewrite" argument.
In the entry, the fields are named 'feeds' and 'pages', whereas the correct parameters to the function "add_permastruct" that gets called eventually are 'feed' and 'paged'.

Change History (10)

#1 @Hanni
11 years ago

Are you talking about the rewrite section on this Codex entry If so, you can edit the page (as with any Codex page) at its edit link which, for this page, can be found here.

#2 @Hanni
11 years ago

  • Keywords needs-codex removed
  • Resolution set to invalid
  • Status changed from new to closed

#3 @Hanni
11 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#4 @beowulfenator
11 years ago

Oh, I didn't know it was user-editable. Fixed it. Thanks!

#5 @beowulfenator
11 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed

#6 @SergeyBiryukov
11 years ago

  • Keywords needs-codex added

That article documents the parameters for register_post_type(), not for add_permastruct().

For register_post_type(), the parameters were correct.

As documented in the inline docs, it's feeds and pages there, not feed and paged:

In line 1316, feeds is mapped to feed (see [24830] for #23302):

Not sure why pages is not mapped, but it appears to be handled above. Probably worth investigating further.

I've reverted the Codex change since it's incorrect.

Last edited 11 years ago by SergeyBiryukov (previous) (diff)

#7 @SergeyBiryukov
11 years ago

  • Keywords needs-codex removed

#8 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review deleted

#9 @beowulfenator
11 years ago

Oops. I was looking at 3.6.1, and there is no such mapping there. But I see it is fixed now. Thanks!

#10 @beowulfenator
11 years ago

I tested this with 3.7.1, and here's what I got:
If register_post_type for a custom post type named "deposits" with 'pages'=>false, the following two rules are created (among others):



However, if I call it with 'paged'=>false, the first rule is not created.

I believe this is incorrect.

Last edited 11 years ago by beowulfenator (previous) (diff)
Note: See TracTickets for help on using tickets.