map_meta_cap() should use parent post status when post has a post status of inherit

[methnen]

When a post has a status of inherit map_meta_cap() fails to use the parent's status and so logic that uses the status to determine the mapping doesn't behave as expected.

For example read_post() will often fail when it should pass. Similarly for delete_post() and edit_post().

This has recently caused a variety of difficulties in a project I've been working on where we have a custom post type that uses the inherit post status on children so authors only need to manage the post status of the main parent post.

The fix is two parts. One a fix to get_post_status() that causes it to check the parent status so it'll work backwards to the first post that has a valid (not 'inherit') post status.

The second is a fix to map_meta_cap() that checks for a post status of inherit on the post object and then uses get_post_status() on the post_parent id value.

A couple related/similar issues:
#23458 (these patches would fix the root issue)
#17668 (fixed)

[methnen]

map_meta_cap_fix

[methnen]

get_post_status_fix

[misterbisson]

+1 one this. I'm biased because we need this to resolve the bugs named above. We make extensive use of custom post types with inherit status on a number of gigaom.com properties.

[antpb]

Attempted to push out the patch but it's been open for 2 years and failed on the apply. Needs a refresh.

[methnen]

@antpb I'll get updated patches in sometime today. Glad to see this getting some attention.

[methnen]

Updated capabilities patch.

[methnen]

Updated post patch.

[methnen]

Updated patches are now attached.

[stevenkword]

26365.diff​ simply combines to previous solution into a single diff.

[johnbillion]

This needs unit test coverage.

[stevenkword]

Note 26365.diff​ will collide with the solution proposed in #23458, which was milestoned for 4.3.

[methnen]

@stevenkword I'm fairly sure that's only the case in the second post.php patch.

map_meta_cap does not ever call on get_post_status and thus still needs to be fixed in order to properly support 'inherit' on custom post types.