map_meta_cap() should use parent post status when post has a post status of inherit
|Reported by:||methnen||Owned by:|
Description (last modified by SergeyBiryukov)
When a post has a status of inherit map_meta_cap() fails to use the parent's status and so logic that uses the status to determine the mapping doesn't behave as expected.
For example read_post() will often fail when it should pass. Similarly for delete_post() and edit_post().
This has recently caused a variety of difficulties in a project I've been working on where we have a custom post type that uses the inherit post status on children so authors only need to manage the post status of the main parent post.
The fix is two parts. One a fix to get_post_status() that causes it to check the parent status so it'll work backwards to the first post that has a valid (not 'inherit') post status.
The second is a fix to map_meta_cap() that checks for a post status of inherit on the post object and then uses get_post_status() on the post_parent id value.
Change History (18)
comment:11 @johnbillion — 4 months ago
- Keywords has-patch needs-unit-tests added; 2nd-opinion needs-refresh needs-patch removed