WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26491 closed defect (bug) (fixed)

Bundled themes: update to latest version of HTML5 Shiv

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: early has-patch commit
Focuses: Cc:

Description

Twenty Eleven to Fourteen are using the HTML5 Shiv file from https://github.com/aFarkas/html5shiv version 3.6.

Looks like 3.7.0 is out now: https://github.com/aFarkas/html5shiv/blob/master/dist/html5shiv.js

Attachments (1)

26491.diff (18.5 KB) - added by rickalee 6 years ago.
Update html5.js to 3.7.0

Download all attachments as: .zip

Change History (7)

#1 @obenland
6 years ago

  • Milestone changed from Future Release to 3.9

I don't see a reason to not do it in 3.9.

@rickalee
6 years ago

Update html5.js to 3.7.0

#2 follow-up: @wonderboymusic
6 years ago

  • Keywords has-patch commit added; needs-patch removed

anything stopping us from doing this? also, why don't we bundle this in core and have all themes point at it (just curious)?

#3 @rickalee
6 years ago

+1 for adding to core.

#4 in reply to: ↑ 2 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Status changed from new to accepted

Replying to wonderboymusic:

anything stopping us from doing this

Sleep, other more urgent work. :)

why don't we bundle this in core and have all themes point at it?

Do we need to? It's lightweight and doesn't need updating very often.

#5 @philiparthurmoore
6 years ago

I'd love to see this in Core; many themes would benefit from it.

#6 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 27263:

Update the HTML5 Shiv across the default themes to 3.7.0.

props rickalee.
fixes #26491.

Note: See TracTickets for help on using tickets.