WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#26538 closed defect (bug) (fixed)

wp_list_authors does not use feed_type

Reported by: MikeHansenMe Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch commit
Focuses: template Cc:

Description

When you call wp_list_authors with feed_type arg it is never accounted for in the function. I found this while writing some unit tests. I also came across another issue with count but I can only reproduce in unit test and not my test site.

Attachments (4)

wp-list-authors-feed-type.diff (465 bytes) - added by MikeHansenMe 7 years ago.
passes feed_type variable to get_author_feed_link
wp-list-authors-unit-tests.diff (9.4 KB) - added by MikeHansenMe 7 years ago.
Unit tests for wp_list_authors
wp-list-author-unit-tests.2.diff (10.1 KB) - added by MikeHansenMe 7 years ago.
better function names and added this ticket number to test that fails
wp-list-author-unit-tests.3.diff (9.6 KB) - added by MikeHansenMe 7 years ago.
Added another ticket number

Download all attachments as: .zip

Change History (8)

@MikeHansenMe
7 years ago

passes feed_type variable to get_author_feed_link

@MikeHansenMe
7 years ago

Unit tests for wp_list_authors

@MikeHansenMe
7 years ago

better function names and added this ticket number to test that fails

#1 @MikeHansenMe
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

  • Component changed from General to Template

@MikeHansenMe
7 years ago

Added another ticket number

#3 @nacin
7 years ago

  • Component changed from Template to Users
  • Focuses template added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9

Thanks Mike! Looks good.

#4 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27550:

Pass feed_type arg in wp_list_authors() to get_author_feed_link().

Adds a slate of tests for wp_list_authors().

props MikeHansenMe.
fixes #26538.

Note: See TracTickets for help on using tickets.