WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#26542 closed defect (bug) (fixed)

Page templates - localization does not work for 2014

Reported by: pavelevap Owned by: matt
Milestone: 3.8 Priority: highest omg bbq
Severity: blocker Version: 3.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

I am not sure what can be wrong, but even if I translated Page Template name (Full Width Page), name is still in English in related dropdown.

It works with 2012, but does not work with 2014.

Attachments (2)

26542.patch (917 bytes) - added by SergeyBiryukov 15 months ago.
es_ES.png (530.0 KB) - added by lancewillett 15 months ago.
Theme description working correctly with es_ES.mo

Download all attachments as: .zip

Change History (12)

@SergeyBiryukov15 months ago

comment:1 @SergeyBiryukov15 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

Confirmed. Caused by missing Text Domain declaration in style.css.

comment:2 @pavelevap15 months ago

Good catch, I thought that I am crazy :-)

comment:3 @nacin15 months ago

  • Keywords commit added
  • Severity changed from normal to blocker

This is needed for translatable theme headers and theme language packs.

We should add a unit test to verify all themes have this header set.

comment:4 @lancewillett15 months ago

I'll ping Otto to add this to Theme Check plugin blockers.

comment:5 @nacin15 months ago

  • Priority changed from normal to highest omg bbq

This is without a doubt a huge blocker.

For anyone that is running non-English and updates WordPress to 3.8, they won't be able to read Twenty Fourteen's description.

comment:6 follow-up: @knutsp15 months ago

I can confirm the issue and that the patch fixes it. But for the theme description, as nacin mentions, I can't get it translated to nb_NO no matter what I do (active/inactive, with or without the patch).

@lancewillett15 months ago

Theme description working correctly with es_ES.mo

comment:7 @lancewillett15 months ago

With this patch applied I can see the theme description correctly translated in wp-admin/themes.php for currently active theme only, using `es_ES.mo` from GlotPress.

Last edited 15 months ago by lancewillett (previous) (diff)

comment:8 @matt15 months ago

We decided in the dev chat this is kosher for 3.8.0.

comment:9 @matt15 months ago

  • Owner set to matt
  • Resolution set to fixed
  • Status changed from new to closed

In 26852:

We forgot the text domain, which made translation break. Fixes #26542.

Props SergeyBiryukov and pavelevap

comment:10 in reply to: ↑ 6 @ocean9015 months ago

Replying to knutsp:

There was a string change in [26850].

Note: See TracTickets for help on using tickets.