Make WordPress Core

Opened 10 years ago

Closed 8 years ago

Last modified 7 years ago

#26559 closed enhancement (fixed)

Remove title attributes: author-template.php

Reported by: joedolson's profile joedolson Owned by:
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch, 2nd-opinion, title-attribute
Focuses: accessibility, template Cc:

Description (last modified by SergeyBiryukov)

Related: #24766

// author-template.php
get_the_author_link()
the_author_posts_link()
wp_list_authors()

Attachments (1)

26559.patch (2.0 KB) - added by joedolson 10 years ago.
Remove title attribute patch for author-template.php

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
10 years ago

  • Description modified (diff)

#2 @joedolson
10 years ago

None of these appear to contribute anything of value.

#3 @joedolson
10 years ago

  • Keywords has-patch added

@joedolson
10 years ago

Remove title attribute patch for author-template.php

#4 @nacin
10 years ago

  • Component changed from Accessibility to Template
  • Focuses accessibility added

#5 @nacin
10 years ago

  • Component changed from Template to Users
  • Focuses template added
  • Milestone changed from Awaiting Review to 3.9

#6 @johnbillion
10 years ago

In 27593:

Remove a redundant title attribute. See #26559. Props joedolson.

#7 @johnbillion
10 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from 3.9 to Future Release
  • Type changed from defect (bug) to enhancement

[27593] removes the redundant title attribute from wp_list_authors() (the title simply mirrors the link text) but leaves the other changes in 26559.patch. Those titles aren't a lot of use but they are different from the link text. Should they stay or should they go?

#8 @afercia
9 years ago

The screenshot below highlights what's left in this ticket. As I see it, some of these title attributes clarify and better describe the link's destination but this would depend on context and the way they're used. Not sure they can be removed. Maybe we should give theme's authors a dedicated function argument?

https://cldup.com/RmELVy3WGG.png

#9 @afercia
8 years ago

Would like to come to a decision here, thinking we have 2 options:

  • provide an additional argument, something like output_title_attr which defaults to true
  • close this ticket :)

Any thoughts welcome.

#10 @obenland
8 years ago

  • Keywords close added

I think we should avoid a flag for this.

#11 @SergeyBiryukov
8 years ago

  • Keywords close removed
  • Milestone changed from Future Release to 3.9
  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed in [27593].

#12 @afercia
7 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.