Make WordPress Core

Opened 13 years ago

Closed 11 years ago

Last modified 6 months ago

#26559 closed enhancement (fixed)

Remove title attributes: author-template.php

Reported by: joedolson Owned by:
Priority: normal Milestone: 3.9
Component: Users Version:
Severity: normal Keywords: has-patch, 2nd-opinion, title-attribute
Cc: Focuses: accessibility, template

Description (last modified by SergeyBiryukov)

Related: #24766

// author-template.php
get_the_author_link()
the_author_posts_link()
wp_list_authors()

Attachments (1)

26559.patch (2.0 KB ) - added by joedolson 13 years ago.
Remove title attribute patch for author-template.php

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
13 years ago

  • Description modified (diff)

#2 @joedolson
13 years ago

None of these appear to contribute anything of value.

#3 @joedolson
13 years ago

  • Keywords has-patch added

@joedolson
13 years ago

Remove title attribute patch for author-template.php

#4 @nacin
13 years ago

  • Component AccessibilityTemplate
  • Focuses accessibility added

#5 @nacin
13 years ago

  • Component TemplateUsers
  • Focuses template added
  • Milestone Awaiting Review3.9

#6 @johnbillion
12 years ago

In 27593:

Remove a redundant title attribute. See #26559. Props joedolson.

#7 @johnbillion
12 years ago

  • Keywords 2nd-opinion added
  • Milestone 3.9Future Release
  • Type defect (bug)enhancement

[27593] removes the redundant title attribute from wp_list_authors() (the title simply mirrors the link text) but leaves the other changes in 26559.patch. Those titles aren't a lot of use but they are different from the link text. Should they stay or should they go?

#8 @afercia
11 years ago

The screenshot below highlights what's left in this ticket. As I see it, some of these title attributes clarify and better describe the link's destination but this would depend on context and the way they're used. Not sure they can be removed. Maybe we should give theme's authors a dedicated function argument?

https://cldup.com/RmELVy3WGG.png

#9 @afercia
11 years ago

Would like to come to a decision here, thinking we have 2 options:

  • provide an additional argument, something like output_title_attr which defaults to true
  • close this ticket :)

Any thoughts welcome.

#10 @obenland
11 years ago

  • Keywords close added

I think we should avoid a flag for this.

#11 @SergeyBiryukov
11 years ago

  • Keywords close removed
  • Milestone Future Release3.9
  • Resolutionfixed
  • Status newclosed

Closing as fixed in [27593].

#12 @afercia
9 years ago

  • Keywords title-attribute added

#13 @joedolson
6 months ago

In 61745:

Users: A11y: Improve title attributes in author link functions.

Remove the title attribute from the_author_posts_link() and related functions, retaining text for use in the_author_posts_link filter, and add parameter to disable title attributes in the_author_link().

Default behavior will still differentiate the two links, but adds the option to remove all title attributes.

Props sabernhardt, alh0319, adnanlimdi, audrasjb, joedolson.
Fixes #62835. See #26559.

Note: See TracTickets for help on using tickets.