Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#26732 closed defect (bug) (fixed)

Twenty Fourteen "featured" tag not hidden on frontend as expected

Reported by: chouby's profile Chouby Owned by: lancewillett's profile lancewillett
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

To reproduce, just activate Twenty Fourteen on a fresh install (optionally visit the customizer to check that the featured tag is "featured" and is not displayed on frontend as default. You are happy with that so do not make any changes).

Create a new post with tag "featured". The "featured" tag appears in the list of tags as well as in the tag cloud.

Attachments (3)

26732.patch (961 bytes) - added by Chouby 10 years ago.
26732.2.patch (1.3 KB) - added by Chouby 10 years ago.
26732.diff (1.0 KB) - added by obenland 10 years ago.

Download all attachments as: .zip

Change History (18)

@Chouby
10 years ago

#1 @Chouby
10 years ago

The patch just proposes to fill featured content settings at theme activation to deal with the case when the featured tag is existing before theme activation.

#2 @celloexpressions
10 years ago

  • Keywords has-patch added

I can confirm that the "featured" tag is not hidden unless you change the option to a different tag, then back to "featured".

#3 follow-up: @Chouby
10 years ago

  • Keywords has-patch removed

26732.patch isn't good as it fires a fatal error

Call to undefined function wp_create_tag() in wp-content/themes/twentyfourteen/inc/featured-content.php on line 517

if the featured tag does not exist

@Chouby
10 years ago

#4 in reply to: ↑ 3 @Chouby
10 years ago

  • Keywords has-patch added

26732.patch isn't good as it fires a fatal error

Should be fixed by 26732.2.patch

NB: I also noticed that it is impossible to delete the "featured" tag (as it is immediately re-created by the function Featured_Content::validate_settings(). Don't know if it is a wanted feature or a bug (as might suggest the comment for Featured_Content::delete_post_tag() ):

Reset tag option when the saved tag is delete

Last edited 10 years ago by Chouby (previous) (diff)

@obenland
10 years ago

#5 @obenland
10 years ago

  • Milestone changed from Awaiting Review to 3.8.1

#6 @nacin
10 years ago

  • Milestone changed from 3.8.1 to 3.8.2

#7 @lancewillett
10 years ago

  • Keywords commit added

#8 @obenland
10 years ago

Patch adds a check for the tag name, in case we're using default values and the default id of 0 does not match the term id of the featured tag.

#9 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 27118:

Twenty Fourteen: make sure featured tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of 0 does not match the term id of the featured tag.

Props obenland, fixes #26732.

#10 @SergeyBiryukov
10 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#11 follow-up: @lancewillett
10 years ago

This isn't major. :)

#12 @lancewillett
10 years ago

Testing note, for Obenland and Jetpack plugin team -- with Jetpack enabled the "Hide tag from tag clouds and post meta" doesn't seem to be working correctly. Works fine with trunk and Twenty Fourteen without Jetpack active.

#13 @lancewillett
10 years ago

Note: Fix for Jetpack is in the works.

#14 in reply to: ↑ 11 @SergeyBiryukov
10 years ago

Replying to lancewillett:

This isn't major. :)

We use "fixed-major" keyword for tickets fixed in the major release and reopened for minor release consideration :) http://make.wordpress.org/core/2011/04/06/the-keywords-fixed-major-and-fixed/

#15 @nacin
10 years ago

  • Milestone changed from 3.8.2 to 3.9
  • Resolution set to fixed
  • Status changed from reopened to closed

lancewillett and I decided that we would be leaving all bundled theme tickets for 3.9. Given the timeline (and lack of severity) we won't be doing a theme update before then.

Note: See TracTickets for help on using tickets.