Opened 13 years ago
Closed 12 years ago
#26856 closed enhancement (fixed)
Twenty Thirteen: Adjust background size of header image(s) with media query
| Reported by: | senlin | Owned by: | lancewillett |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.0 |
| Component: | Bundled Theme | Version: | 3.8 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Although I realise that there are a few similar tickets already, @obenland recently suggested on my blog to open a ticket for this.
In the file inc/custom-header.php I suggest to add media queries for two breakpoints, 360px for smartphones and 768px for tablets.
For these two media queries I have made the background-size 1px bigger than the query. I am not entirely sure whether I should or not, my reasoning merely is the fact that the highest breakpoint is 1599px and the minimum image width is 1600px; I could be completely wrong about this, so please correct me if that is the case.
Gist of file: https://gist.github.com/senlin/6380825#file-custom-header-php-L66-L79
Attachments (3)
Change History (15)
#2
@
13 years ago
- Component Appearance → Bundled Theme
- Keywords needs-patch added
- Summary adjust background size Twenty Thirteen header image(s) with media query → Twenty Thirteen: Adjust background size of header image(s) with media query
#4
in reply to: ↑ 3
@
13 years ago
Replying to lancewillett:
@senlin Can we help you make a patch here in the format Trac expects? I'd be happy to show you how it works.
Yes, that would be much appreciated Lance
#5
follow-up:
↓ 6
@
13 years ago
@senlin I'm lancewillett on Freenode IRC if you want to chat there (#wordpress-themes), or email me lance at simpledream.net and we can go from there.
#6
in reply to: ↑ 5
@
13 years ago
Replying to lancewillett:
@senlin I'm
lancewilletton Freenode IRC if you want to chat there (#wordpress-themes), or email me lance at simpledream.net and we can go from there.
I have no idea what IRC is and therefore sent you an email from piet at senlinonline
#8
@
13 years ago
- Milestone 3.9 → Future Release
Let's keep working on it and see if it might be something for 4.0
@senlin Can we help you make a patch here in the format Trac expects? I'd be happy to show you how it works.