Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27661 closed defect (bug) (fixed)

Theme Install: Feature filter layout at 1024px

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: matveb's profile matveb
Milestone: 3.9 Priority: normal
Severity: minor Version: 3.9
Component: Themes Keywords: has-patch
Focuses: ui Cc:

Description

On new theme install screen, feature filter layout looks weird at 1024px (see the screenshot).

Attachments (5)

27661.png (59.4 KB) - added by SergeyBiryukov 10 years ago.
27661.patch (402 bytes) - added by SergeyBiryukov 10 years ago.
27661.after.png (55.9 KB) - added by SergeyBiryukov 10 years ago.
27661.2.diff (2.2 KB) - added by matveb 10 years ago.
27661.3.diff (2.5 KB) - added by matveb 10 years ago.

Download all attachments as: .zip

Change History (10)

@SergeyBiryukov
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Keywords has-patch added

Looks better to me with 27661.patch.

#2 @nacin
10 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

#3 @nacin
10 years ago

  • Owner changed from nacin to matveb

I meant this for matveb.

#4 @matveb
10 years ago

I don't have a strong preference here, if we wanted to we could make sure in JavaScript every two boxes had the same height, but that is probably overkill. Depends on how much we want to invest in it. I'm fine with this change since Columns and Layouts are not likely to grow much in size soon.

@matveb
10 years ago

@matveb
10 years ago

#5 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27959:

Theme Installer: Better responsive styles for feature filters.

props matveb.
fixes #27661.

Note: See TracTickets for help on using tickets.