Make WordPress Core

Opened 8 years ago

Last modified 4 months ago

#27697 new defect (bug)

wp-admin.css class="hidden" bug renders screen options menu in admin blank

Reported by: grabmedia Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.8.1
Component: General Keywords: has-patch needs-testing
Focuses: ui, javascript, administration Cc:


One of the publishers who uses our GrabPress plugin brought a serious issue to our attention. Initially they thought it was a bug with our plugin, but after looking further into the issue, it's clear that the issue is within the WordPress admin files.

The Screen Options menu at the top of the WordPress admin dashboard becomes unusable, and the form elements appear hidden. Reproducing this issue was difficult to track, mainly because it just depends on when other CSS files conflict with it (which can be many). It leaves the '.hidden' class out there to potentially conflict against any other CSS file in the environment that uses the 'visibility:hidden' property instead of or in addition to 'display:none'

One of our developers took a closer look and found the following.

In the PHP file where the original state of the HTML for the screen options UI that is experiencing the issue is formed you'll see that the class="hidden" is present.
wp-admin/includes/screen.php (line 917)

<div id="screen-options-wrap" class="hidden" tabindex="-1" aria-label="<?php esc_attr_e('Screen Options Tab'); ?>">

They have this class tied up to the following CSS: wp-admin/css/wp-admin.css (line 234 thru 243)

.js .closed .inside,
.js .hide-if-js,
.no-js .hide-if-no-js,
.js.wp-core-ui .hide-if-js,
.js .wp-core-ui .hide-if-js,
.no-js.wp-core-ui .hide-if-no-js,
.no-js .wp-core-ui .hide-if-no-js {
	display: none;

So you can see that the '.hidden' class (along with several others) has the property 'display: none;'. This is perfectly fine and normal if they plan to toggle on and off the '.hidden' class from the element. However they instead make use of jQuery's 'show()' and 'hide()' methods and leave the 'hidden' class.
wp-admin/js/common.js (lines 99 thru 143)

screenMeta = {
	element: null, // #screen-meta
	toggles: null, // .screen-meta-toggle
	page:    null, // #wpcontent

	init: function() {
		this.element = $('#screen-meta');
		this.toggles = $('.screen-meta-toggle a');    = $('#wpcontent'); this.toggleEvent );

	toggleEvent: function( e ) {
		var panel = $( this.href.replace(/.+#/, '#') );

		if ( !panel.length )

		if (':visible') )
			screenMeta.close( panel, $(this) );
		else panel, $(this) );

	open: function( panel, link ) {

		$('.screen-meta-toggle').not( link.parent() ).css('visibility', 'hidden');

		panel.slideDown( 'fast', function() {
			link.addClass('screen-meta-active').attr('aria-expanded', true);

	close: function( panel, link ) {
		panel.slideUp( 'fast', function() {
			link.removeClass('screen-meta-active').attr('aria-expanded', false);
			$('.screen-meta-toggle').css('visibility', '');

The use of these methods is also okay. The 'show()' and 'hide()' methods toggle the element's display value between 'display:none' and 'display:block'. The issue here is that WP used the '.hidden' class to set the default display state and then use the Jquery toggle methods to adjust on the fly. However, this leaves the '.hidden' class out there to snag itself in conflict against any CSS at play that uses the 'visibility:hidden' property instead of or in addition to 'display:none'. Twitter Bootstrap for example, which GrabPress uses and is widely used across the web has the following declaration for '.hidden':

.hidden {
  display: none;
  visibility: hidden;

So my recommendation to WP would be to have their JavaScript toggle on/off the class 'hidden' from the element rather than leaving it there. To have 'hidden' on a unhidden element just makes no sense, even semantically speaking. It might also be good for them to toggle both the 'display' property and the 'visibility' property of the element.

Attachments (4)

GBPS-263-screenoptions-missing.png (128.1 KB) - added by grabmedia 8 years ago.
screen.php (27.7 KB) - added by grabmedia 8 years ago.
the changes attached here to screen.php would likely resolve this issue
27697.diff (770 bytes) - added by sabernhardt 4 months ago.
27697.1.diff (740 bytes) - added by sabernhardt 4 months ago.
removeClass needed to be inside slideDown function

Download all attachments as: .zip

Change History (11)

8 years ago

the changes attached here to screen.php would likely resolve this issue

This ticket was mentioned in IRC in #wordpress-dev by Clorith. View the logs.

8 years ago

#2 @SergeyBiryukov
8 years ago

  • Component changed from Menus to Administration
  • Focuses ui added

Could you please attach an SVN patch rather than a PHP file?


#3 @SergeyBiryukov
8 years ago

  • Keywords needs-patch added

I saw this issue before, caused by .hidden class usage in some theme framework. Would be nice to fix this.

#4 @helen
7 years ago

  • Component changed from Administration to General
  • Focuses javascript administration added

I agree that we should be toggling classes more often than setting CSS directly with JS (which is effectively what show() and hide() do). Would like to see a patch here. If we are worried about unintended side effects, we can add an .is-hidden class.

However, I do want to note that on the whole I'm not really concerned about working around problems that arise from loading another admin framework (like Bootstrap) within the WordPress admin. I know core doesn't always provide all the UI tools needed, but there's enough generically named stuff in wp-admin.css that loading up another framework inside is almost definitely going to have side effects.

#5 @sabernhardt
6 months ago

  • Milestone set to Future Release

#6 @sabernhardt
4 months ago

#54165 was marked as a duplicate.

4 months ago

#7 @sabernhardt
4 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

I expect that the script could be better, but 27697.diff simply removes the hidden class when the panel element is not hidden (and adds the class again when the panel closes).

4 months ago

removeClass needed to be inside slideDown function

Note: See TracTickets for help on using tickets.