Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#27949 closed enhancement (fixed)

Media modal: attachment details: border around mime type icon

Reported by: iseulde's profile iseulde Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch
Focuses: ui Cc:

Description

Not sure if this is wanted or not, but it appears a bit strange.

Attachments (3)

Screen Shot 2014-04-21 at 09.41.07.png (13.9 KB) - added by iseulde 11 years ago.
27949.patch (921 bytes) - added by iseulde 11 years ago.
media-template.patch (950 bytes) - added by 5um17 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @helen
11 years ago

It would probably be better without them for mime type icons - does the markup allow to target them, though?

@iseulde
11 years ago

#2 @iseulde
11 years ago

  • Keywords has-patch added

No, but we can always add markup. :) Patch above. Not sure if this is a bug or enhancement.

#3 @5um17
11 years ago

We do not have any selector to target the parent as we have icon class only on image tag.
patch 27949.patch is removing class thumbnail which result in removing some css rules. better if we can add another class to div?

#4 @5um17
11 years ago

I am sorry i did not test well. 27949.patch seems good.

#5 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28369:

In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border.

Props avryl.
Fixes #27949.

#6 @wonderboymusic
11 years ago

  • Milestone changed from Awaiting Review to 4.0
Note: See TracTickets for help on using tickets.