Make WordPress Core

Opened 10 years ago

Last modified 19 months ago

#28163 new defect (bug)

function email_exists() check without removing umlauts

Reported by: hpr78's profile hpr78 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8.3
Component: Users Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

But with wp_insert_user() the umlauts got removed.
A littel bit confusing.

Attachments (3)

user.php.patch (512 bytes) - added by dots 10 years ago.
We have attached the patch file. It will remove "umlauts" before existing email check.
28163.patch (617 bytes) - added by binarygary 7 years ago.
Unit Test for 28163
28163.test.diff (645 bytes) - added by johnregan3 19 months ago.
Refreshed Test for 28163

Download all attachments as: .zip

Change History (8)

@dots
10 years ago

We have attached the patch file. It will remove "umlauts" before existing email check.

#1 @dots
10 years ago

  • Keywords has-patch added

#2 @chriscct7
8 years ago

  • Keywords needs-unit-tests added

@binarygary
7 years ago

Unit Test for 28163

#3 @azouamauriac
2 years ago

  • Keywords needs-refresh added

@johnregan3
19 months ago

Refreshed Test for 28163

#4 @johnregan3
19 months ago

  • Keywords needs-unit-tests needs-refresh removed

After updating the Test patch it is apparent that the original patch (user.php.patch) is no longer needed. The sanitize_email() call is now handled in wp-includes/default-filters.php using the 'pre_user_email' filter.

// Email saves.
foreach ( array( 'pre_comment_author_email', 'pre_user_email' ) as $filter ) {
	add_filter( $filter, 'trim' );
	add_filter( $filter, 'sanitize_email' );
	add_filter( $filter, 'wp_filter_kses' );
}

#5 @johnregan3
19 months ago

  • Keywords has-unit-tests added
Note: See TracTickets for help on using tickets.