Make WordPress Core

Opened 11 years ago

Closed 9 years ago

#28201 closed enhancement (fixed)

Update overview help docs for translations updates

Reported by: netweb's profile netweb Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.4 Priority: low
Severity: minor Version: 3.9.1
Component: Upgrade/Install Keywords: has-patch commit
Focuses: docs Cc:

Description

Using the help docs tab at Dashboard -> Updates:

Overview Current:
On this screen, you can update to the latest version of WordPress, as well as update your themes and plugins from the WordPress.org repositories.

Overview Proposed:
On this screen, you can update to the latest version of WordPress, as well as update your themes, plugins and translations from the WordPress.org repositories.

Patch attached adds the same check used for the 'How to update' section of the same help docs (src) and only displays the new string if the locale is not en_US.

Attachments (3)

28201.patch (1.2 KB) - added by netweb 11 years ago.
28201.2.patch (1.2 KB) - added by netweb 11 years ago.
28201.3.patch (1023 bytes) - added by DrewAPicture 9 years ago.

Download all attachments as: .zip

Change History (21)

@netweb
11 years ago

#1 @netweb
11 years ago

  • Keywords has-patch added

#2 @ocean90
11 years ago

  • Milestone changed from Awaiting Review to 4.0
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement

#3 @DrewAPicture
11 years ago

Good call. Core style is to use the Oxford comma, but otherwise, +1.

@netweb
11 years ago

#4 @netweb
11 years ago

28201.2.patch​ = Oxfordified ;)

#5 @DrewAPicture
11 years ago

  • Keywords commit added

28201.2.patch looks good to me.

#7 @DrewAPicture
11 years ago

  • Owner set to nacin
  • Status changed from new to reviewing

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


11 years ago

#9 @ocean90
11 years ago

"translations from the WordPress.org repositories" doesn't make sense to me.

#10 @SergeyBiryukov
11 years ago

nacin: I have always wanted language packs to work as seamless and as quietly as possible.
nacin: it's the same reason why I give exactly zero care points for #28199
trac-bot: nacin: http://core.trac.wordpress.org/ticket/28199 4.0, netweb->(no owner), new, Improve upgrade translations verbiage
nacin: this stuff affects us and no one else. real-world users just want their WordPress to work.
nacin: but I am open to ideas and counter-views.

http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-06-18&sort=asc#m871481

#11 @netweb
11 years ago

Per the IRC discussion and just as #28199 has been punted, I'd suggest also punting this to 'Future Release'.

We can revisit after all the 4.0 Internationalization bits are in if needed.

#12 @ocean90
11 years ago

  • Keywords commit removed
  • Milestone changed from 4.0 to Future Release

#13 @DrewAPicture
9 years ago

@ocean90: Do you have any follow-up thoughts on this now that language packs have kind of settled?

#14 @ocean90
9 years ago

I'm fine with 28201.2.patch, but without the get_locale() check since it can update all locales/translation files.

#15 @DrewAPicture
9 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 4.4

#16 @DrewAPicture
9 years ago

28201.3.patch updates the standard message for all locales per comment:14.

#17 @DrewAPicture
9 years ago

  • Owner nacin deleted

#18 @wonderboymusic
9 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reviewing to closed

In 33704:

update-core.php help docs, update string to include translations: themes, plugins, and translations

Props netweb, DrewAPicture.
Fixes #28201.

Note: See TracTickets for help on using tickets.