WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29012 closed defect (bug) (wontfix)

Media modal close icon should be consistent with other modals

Reported by: celloexpressions Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: ui Cc:

Description

Many of our newer modals use close and arrow icons with borders and a bold background color on focus. Currently, this includes the theme browser, Customizer, media grid details, and probably others.

The media modal should have a similarly-styled close button, probably without the borders. Now that the close button is auto-focused, it needs a more beautiful styling that is consistent with other auto-focused icons (like the Customizer close icon). Otherwise it looks like a bug (#28969).

Patch also cleans up media grid overrides of the modal styling to make it look like the newer-style close icons.

Attachments (5)

29012.diff (2.7 KB) - added by celloexpressions 6 years ago.
Use media grid close styling for media modal, key media grid & modal icons to color schemes.
29012.png (98.7 KB) - added by celloexpressions 6 years ago.
29012.focus-hover.png (99.2 KB) - added by celloexpressions 6 years ago.
29012.media-grid.png (154.5 KB) - added by celloexpressions 6 years ago.
29012.1.diff (3.1 KB) - added by celloexpressions 6 years ago.

Download all attachments as: .zip

Change History (9)

@celloexpressions
6 years ago

Use media grid close styling for media modal, key media grid & modal icons to color schemes.

#1 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [29287].

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


6 years ago

#3 @helen
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reverting [29287], then handling further changes in #29147.

#4 @helen
6 years ago

  • Milestone 4.0 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.