WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 2 years ago

#29086 closed defect (bug) (fixed)

Inline docs for wp-admin/includes/class-wp-upgrader.php

Reported by: jdgrimes Owned by: DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch
Focuses: docs Cc:
PR Number:

Description

Most of wp-admin/includes/class-wp-upgrader.php doesn't have inline docs, though hook docs have been added throughout.

Attachments (3)

29086.diff (24.1 KB) - added by jdgrimes 5 years ago.
First run
29086.2.diff (24.8 KB) - added by jdgrimes 5 years ago.
29086.3.diff (474 bytes) - added by kraftbj 5 years ago.
Corrects typo in [30758] (s/plugins/themes)

Download all attachments as: .zip

Change History (13)

@jdgrimes
5 years ago

First run

#1 @jdgrimes
5 years ago

  • Keywords has-patch added

Initial patch, will probably need some work.

#2 @DrewAPicture
5 years ago

  • Keywords needs-refresh added
  • Type changed from enhancement to defect (bug)
  • Version 2.8 deleted

Hi J.D., sorry we didn't work our way around to your patch until just now. I'm seeing 2 out of 40 failures in applying your patch. Would you mind refreshing it?

patching file src/wp-admin/includes/class-wp-upgrader.php
Hunk #1 FAILED at 21.
Hunk #2 succeeded at 78 (offset 2 lines).
Hunk #3 FAILED at 118.
Hunk #4 succeeded at 177 (offset 4 lines).
Hunk #5 succeeded at 219 (offset 4 lines).
Hunk #6 succeeded at 268 (offset 4 lines).
Hunk #7 succeeded at 467 (offset 4 lines).
Hunk #8 succeeded at 588 (offset 4 lines).
Hunk #9 succeeded at 623 (offset 4 lines).
Hunk #10 succeeded at 655 (offset 4 lines).
Hunk #11 succeeded at 670 (offset 4 lines).
Hunk #12 succeeded at 719 (offset 4 lines).
Hunk #13 succeeded at 785 (offset 4 lines).
Hunk #14 succeeded at 914 (offset 4 lines).
Hunk #15 succeeded at 952 (offset 4 lines).
Hunk #16 succeeded at 976 (offset 4 lines).
Hunk #17 succeeded at 1002 (offset 4 lines).
Hunk #18 succeeded at 1048 (offset 4 lines).
Hunk #19 succeeded at 1080 (offset 4 lines).
Hunk #20 succeeded at 1105 (offset 4 lines).
Hunk #21 succeeded at 1171 (offset 4 lines).
Hunk #22 succeeded at 1236 (offset 4 lines).
Hunk #23 succeeded at 1301 (offset 4 lines).
Hunk #24 succeeded at 1418 (offset 5 lines).
Hunk #25 succeeded at 1458 (offset 5 lines).
Hunk #26 succeeded at 1482 (offset 5 lines).
Hunk #27 succeeded at 1512 (offset 5 lines).
Hunk #28 succeeded at 1539 (offset 5 lines).
Hunk #29 succeeded at 1575 with fuzz 1 (offset 5 lines).
Hunk #30 succeeded at 1647 with fuzz 1 (offset 36 lines).
Hunk #31 succeeded at 1662 with fuzz 2 (offset 36 lines).
Hunk #32 succeeded at 1686 (offset 43 lines).
Hunk #33 succeeded at 1808 (offset 47 lines).
Hunk #34 succeeded at 1841 (offset 47 lines).
Hunk #35 succeeded at 1881 (offset 47 lines).
Hunk #36 succeeded at 1897 (offset 47 lines).
Hunk #37 succeeded at 2061 (offset 48 lines).
Hunk #38 succeeded at 2168 (offset 48 lines).
Hunk #39 succeeded at 2203 (offset 48 lines).
Hunk #40 succeeded at 2290 (offset 48 lines).
2 out of 40 hunks FAILED

@jdgrimes
5 years ago

#3 @jdgrimes
5 years ago

  • Keywords needs-refresh removed

Refreshed in 29086.2.diff.

#4 @DrewAPicture
5 years ago

In 30758:

Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader.

Props jdgrimes, DrewAPicture.

See #29086.

#5 @DrewAPicture
5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release

@jdgrimes: I committed all of your work up to 29086.2.diff. There were still a few parameters and returns missing description that I'd like to get handled before we close this ticket out. Is that something you're up for?

@kraftbj
5 years ago

Corrects typo in [30758] (s/plugins/themes)

#6 @DrewAPicture
4 years ago

  • Milestone changed from Future Release to 4.4

#7 @DrewAPicture
4 years ago

In 33683:

Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property.

Also adds a couple of missing @access tags.

Props kraftbj
See #29086.

#8 @DrewAPicture
4 years ago

In 33684:

Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader.

See #29086.

#9 @DrewAPicture
4 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 33685:

Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.

Fixes #29086.

#10 @SergeyBiryukov
2 years ago

In 41914:

Docs: Add @since entry for WP_Automatic_Updater::after_core_update(), introduced in [25841].

See #41017, #29086.

Note: See TracTickets for help on using tickets.