WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#29092 closed defect (bug) (fixed)

Plugin install: Groups can't be translated

Reported by: ocean90's profile ocean90 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Plugins Keywords: dev-feedback
Focuses: administration Cc:

Description

See [29225].

Patch adds "Performance", "Social" and "Tools", but not sure how many group names are currently available.

Attachments (2)

29092.patch​ (878 bytes) - added by ocean90 11 years ago.
29092.2.patch​ (1.3 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (8)

@ocean90
11 years ago

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. ​View the logs.
11 years ago

@SergeyBiryukov
11 years ago

#2 @SergeyBiryukov
11 years ago

  • Keywords commit added

29092.2.patch​ takes the same approach we use for tabs in install_plugin_information()​.

#3 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29477:

Plugin install: Make plugin groups translatable.

props ocean90 for initial patch.
fixes #29092.

#4 @nacin
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

These groups are fungible and won't be the same once the featured list is overhauled shortly after 4.0. I suspect we'll translate any strings and serve them up directly from .org over the API request. I think this can probably be reverted.

#5 @nacin
11 years ago

  • Keywords dev-feedback added; has-patch commit removed

#6 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

We can safely leave this code in for 4.0, but note I have removed groups from the API and we'll being them back when they aren't placeholder groups (and with translations).

Note: See TracTickets for help on using tickets.