plugin_basename() doesn't normalize the file path before unresolving symlinks

[jdgrimes]

In plugin_basename(), the $file is only passed through wp_normalize_path() after the attempt to unresolve symlinks. It should be normalized before this instead.

Introduced in: [27158]
Related: #16953, #28441

[voldemortensen]

Refreshed for current trunk.

[flyingdr]

Any idea why this trivial patch waits for almost 2 years to be applied?

Latest available version 4.5 is still affected by this problem.

[flyingdr]

I've tested 29154.2.diff on several sites that uses symlinks for plugins. It really solves problem with broken plugins in a case if they're installed using symlinks. Would be great to see this patch in 4.5.x or 4.6

[flyingdr]

Created patch against current trunk (rev.37295)

[ocean90]

29154.3.diff​ includes a unit test which fails without the change to plugin_basename():

1) Tests_Plugin_Basename::test_should_return_correct_basename_for_symlinked_plugins
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-a-symlinked-plugin/plugin.php
+C:/www/path/plugins/a-plugin/plugin.php

[ocean90]

In 37332:

Plugins: In plugin_basename() normalize the file path before unresolving symlinks.

$wp_plugin_paths contains normalized paths, see wp_register_plugin_realpath().

Props jdgrimes, voldemortensen, flyingdr, ocean90.
Fixes #29154.

[SergeyBiryukov]

In 37719:

Plugins: Normalize WP_PLUGIN_DIR in the test added in [37332], otherwise it fails on Windows.

See #29154.

[SergeyBiryukov]

Replying to ocean90:

29154.3.diff​ includes a unit test which fails without the change to plugin_basename()

For reference, the test still failed on my install after [37332]:

1) Tests_Plugin_Basename::test_should_return_correct_basename_for_symlinked_plugins
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-a-symlinked-plugin/plugin.php
+S:\home\wordpress\develop/src/wp-content/plugins/a-symlinked-plugin/plugin.php

[37719] fixes that.