#29154 closed defect (bug) (fixed)
plugin_basename() doesn't normalize the file path before unresolving symlinks
Reported by: | jdgrimes | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | Plugins | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Attachments (4)
Change History (13)
This ticket was mentioned in Slack in #core by jorbin. View the logs.
9 years ago
#4
@
8 years ago
Any idea why this trivial patch waits for almost 2 years to be applied?
Latest available version 4.5 is still affected by this problem.
#5
@
8 years ago
- Keywords needs-testing added
I've tested 29154.2.diff on several sites that uses symlinks for plugins. It really solves problem with broken plugins in a case if they're installed using symlinks. Would be great to see this patch in 4.5.x or 4.6
#6
follow-up:
↓ 9
@
8 years ago
- Keywords has-unit-tests added; needs-testing removed
- Milestone changed from Awaiting Review to 4.6
29154.3.diff includes a unit test which fails without the change to plugin_basename()
:
1) Tests_Plugin_Basename::test_should_return_correct_basename_for_symlinked_plugins Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -a-symlinked-plugin/plugin.php +C:/www/path/plugins/a-plugin/plugin.php
#7
@
8 years ago
- Owner set to ocean90
- Resolution set to fixed
- Status changed from new to closed
In 37332:
#9
in reply to:
↑ 6
@
8 years ago
Replying to ocean90:
29154.3.diff includes a unit test which fails without the change to
plugin_basename()
For reference, the test still failed on my install after [37332]:
1) Tests_Plugin_Basename::test_should_return_correct_basename_for_symlinked_plugins Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -a-symlinked-plugin/plugin.php +S:\home\wordpress\develop/src/wp-content/plugins/a-symlinked-plugin/plugin.php
[37719] fixes that.
Note: See
TracTickets for help on using
tickets.
Refreshed for current trunk.