WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#29166 closed defect (bug) (fixed)

Update TinyMCE to 4.1.3

Reported by: azaozz Owned by: azaozz
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

Was released few days ago.

Attachments (2)

29166.diff (599 bytes) - added by celloexpressions 3 years ago.
Set focus in media modal *after* blurring to hide onscreen keyboards.
close-button.png (1.0 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (10)

#1 @azaozz
3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 29458:

TinyMCE: update to 4.1.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt, fixes #29166

#2 @azaozz
3 years ago

In 29463:

TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595, #29166

#3 @azaozz
3 years ago

In [29471]:

TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595, #29166

@celloexpressions
3 years ago

Set focus in media modal *after* blurring to hide onscreen keyboards.

#4 follow-up: @celloexpressions
3 years ago

  • Keywords has-patch added

[29471] completely broke keyboard accessibility for the add media panel (see #23560), as focus is blurred when it's opened (so users can't even get into it). We need to do the try-to-hide-an-onscreen-keyboard part before setting focus on the close link, or keyboard users whose device happens to support touch basically can't use the media modal at all.

This seems like the more relevant ticket to reopen. 29166.diff fixes.

#5 @celloexpressions
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@azaozz
3 years ago

#6 in reply to: ↑ 4 ; follow-up: @azaozz
3 years ago

Replying to celloexpressions:

Yep, patch works well. Btw, why are we focusing the Close button? Looks kind of bad :)

Shouldn't we focus a div that has tabindex="-1" and some explanation in a screen-reader-text or aria-describedby that a modal has just opened?

#7 @azaozz
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29473:

Media modal: make sure the Close button is focused after attempting to close the onscreen keyboard on touch devices. Props celloexpressions, fixes #29166.

#8 in reply to: ↑ 6 @celloexpressions
3 years ago

Replying to azaozz:

Replying to celloexpressions:

Yep, patch works well. Btw, why are we focusing the Close button? Looks kind of bad :)

Shouldn't we focus a div that has tabindex="-1" and some explanation in a screen-reader-text or aria-describedby that a modal has just opened?

That's the best place to put focus, also being consistent with other places in wp-admin, so that the focus is visible (keyboard accessibility applying primarily to sighted users who are unable to use a mouse). #29012 made it look good, but it had to be reverted because the colorful hover/focus styling was disliked, so the plan is to come up with a new pattern for close icons and use it here too.

Note: See TracTickets for help on using tickets.