When publishing a non-public post type post

[slobodanmanic]

A similar problem was fixed in [24799] (removes preview button for non-public post types), but when you first publish a non-public post there's still that "Post published. View post" notice.

[slobodanmanic]

Same problem with "Post updated", "Post draft updated" "Post submitted" and "Post scheduled for:", working on a patch for this.

[slobodanmanic]

This fixes the issue, but there's some duplicate code, I'd love to hear a second opinion on it.

[DrewAPicture]

Hi, thanks for the ticket. This issue has been raised several times before in other tickets, though in #17609 it was suggested to create a new ticket for updating these messages. This should suffice.

I think @jfarthing84 makes a good point in comment:33:ticket:17609 in that we should probably be checking publicly_queryable instead of public as the former is really what we're dealing with. And if publicly_queryable isn't set, it falls back to the value of public anyway.

29375.2.diff​ addresses your DRY concerns.

Related: #17609.

[johnbillion]

This is still a dupe of #17609. Let's keep the conversation in one place.