Opened 11 years ago
Closed 11 years ago
#29466 closed enhancement (fixed)
Increase the min-height of plugin cards to match the height of cards with a four line description
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.0 | Priority: | normal |
| Severity: | minor | Version: | 4.0 |
| Component: | Plugins | Keywords: | has-patch commit dev-reviewed |
| Focuses: | ui, administration | Cc: |
Description
The min-height of the new plugin cards is set to the height of a card when the description wraps to three lines.
We should increase this to the height of a card when the description has four lines, because the description for many plugins in repo wraps to four lines on this screen. This will normalise the height of the cards a little more.
Marking as 4.0 for review. Thoughts?
Related: #29465
Attachments (1)
Change History (8)
#1
@
11 years ago
- Keywords needs-patch ui-feedback removed
- Milestone 4.0 deleted
- Resolution set to duplicate
- Status changed from new to closed
#2
@
11 years ago
- Milestone set to 4.0
- Resolution duplicate deleted
- Status changed from closed to reopened
I don't necessarily think this is a duplicate, but I went to check this out now that we've added icons. It ends up being too tall to make four lines be the min height, but we need to increase it anyway because of the icon. I think we should also do a little more adjustment around the icon so the text doesn't get squished between the two things coming in on the sides - will work on this for a bit.
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
11 years ago
#5
@
11 years ago
- Keywords commit added
29466.diff tweaks styling so that we don't get orphaned words or squished text. It makes the HTML and thus tab ordering a bit more sensible - puts the action links after the title, which is reflected at some viewport sizes. Also changes the min-height of the card to reflect the icon - essentially, these are all changes around better accommodating the plugin icons.
Duplicate of #29372.