Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#29946 closed defect (bug) (fixed)

Wrong panel-back icon in Customizer in RTL

Reported by: celloexpressions's profile celloexpressions Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: low
Severity: minor Version: 4.0
Component: Customize Keywords: good-first-bug has-patch commit
Focuses: ui, rtl Cc:

Description

We forgot to switch it to the arrow without a center line when we did that for all of the arrows in modals, etc. in the admin. The f344 dashicon should be f345.

Attachments (6)

29946.png (5.0 KB) - added by celloexpressions 9 years ago.
customize-controls-rtl.diff (338 bytes) - added by TomHarrigan 9 years ago.
fixing rtl arrow in customize-controls-rtl.css
customize-controls-rtl.2.diff (377 bytes) - added by TomHarrigan 9 years ago.
make arrow patch from wp root dir
customize-controls-rtl.min.diff (31.1 KB) - added by TomHarrigan 9 years ago.
minified css of arrow change
customize-controls.diff (365 bytes) - added by TomHarrigan 9 years ago.
fixing rtl arrow in customize-controls.css
customize-controls.min.diff (31.1 KB) - added by TomHarrigan 9 years ago.
fixing rtl arrow in customize-controls.min.css

Download all attachments as: .zip

Change History (10)

@TomHarrigan
9 years ago

fixing rtl arrow in customize-controls-rtl.css

@TomHarrigan
9 years ago

make arrow patch from wp root dir

@TomHarrigan
9 years ago

minified css of arrow change

@TomHarrigan
9 years ago

fixing rtl arrow in customize-controls.css

@TomHarrigan
9 years ago

fixing rtl arrow in customize-controls.min.css

#1 @adamsilverstein
9 years ago

  • Focuses ui added
  • Keywords has-patch added; needs-patch removed

This looks good Tom, thanks!

Quick note that there is no need to create the separate patches for the RTL and .min file variants, these are generated as part of the WordPress build process. (Typing 'grunt build' in the trunk directory)

I applied the patch and verified the arrow looks correct now in RTL mode:

http://f.cl.ly/items/0f310V2H0Y2I0Z3S0T2O/___Destro___2014-10-14_20-56-22.jpg

#2 @TomHarrigan
9 years ago

Replying to adamsilverstein:
Many thanks, appreciate the tip Adam :)

#3 @celloexpressions
9 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 4.1

#4 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29955:

Customizer: Use correct panel-back icon in RTL.

props TomHarrigan.
fixes #29946.

Note: See TracTickets for help on using tickets.