Opened 10 years ago
Closed 10 years ago
#30133 closed defect (bug) (fixed)
Twenty Fifteen: minor file cleanup
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Looking at things like removing trailing whitespace, SVN executable, SVN properties, EOL consistency in newlines.
Attachments (4)
Change History (18)
This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.
10 years ago
#11
in reply to:
↑ 4
@
10 years ago
Replying to lancewillett:
In 30044:
esc_attr()
is just for attributes, because it escapes the quotes.
var_dump(' style="color: #fff;"' === esc_attr( ' style="color: #fff;"') ); // false var_dump(' style="color: #fff;"' === ' style="' . esc_attr( 'color: #fff;') . '"' ); // true
So in line 152 sprintf( ' style="color: #%s;"', esc_attr( get_header_textcolor() ) );
should be fine.
Note: See
TracTickets for help on using
tickets.
Should crush all PNG image files also.